Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT #3: Correct a typo in 'revocationpubkey derivation' #664

Closed
wants to merge 1 commit into from

Conversation

@darosior
Copy link
Contributor

commented Sep 2, 2019

I think pubkey was meant instead of privkey.

@t-bast

This comment has been minimized.

Copy link
Collaborator

commented Sep 2, 2019

I think the current wording is correct.
We really mean private key here.
Both peers know the public key (because it's computed from basepoints) but in order to know the corresponding private key (to spend a revoked commitment) you need the private part of either the revocation part of the per-commitment part.

@t-bast

This comment has been minimized.

Copy link
Collaborator

commented Sep 2, 2019

The key derivation part is tricky and can be confusing at times ;)

@darosior

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

I think the current wording is correct.
We really mean private key here.
Both peers know the public key (because it's computed from basepoints) but in order to know the corresponding private key (to spend a revoked commitment) you need the private part of either the revocation part of the per-commitment part.

Ok, reading it again it seems like I've got confused ^^. Thanks

@darosior darosior closed this Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.