Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 7: gossip_query_ex typos. #673

Merged
merged 3 commits into from Sep 30, 2019

Conversation

@rustyrussell
Copy link
Collaborator

commented Sep 19, 2019

These fixes make our implementation compile again :) They match what we had implemented, and what the spec actually says, too.

This is `reply_channel_range_tlvs`: `query_channel_range_tlvs` is defined
above.  Somehow this fix got lost in the merge process, and breaks
our spec parsing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the rustyrussell:fix-query-typo branch from 839d264 to cc8af54 Sep 19, 2019
…tlvs / reply_channel_range_tlvs

The implementations have it, and the requirements refer to it,
but it's not actually in the description!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
As agreed in http://www.erisian.com.au/meetbot/lightning-dev/2019/lightning-dev.2019-08-05-20.03.html,
checksums are not encoded as encoding_type + byte, but as a straight
array.  Referring to them as `*byte` is thus underspecifying them:
they are literally `*channel_update_checksums`.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell force-pushed the rustyrussell:fix-query-typo branch from cc8af54 to 52ced9f Sep 19, 2019
@rustyrussell rustyrussell changed the title BOLT 7: fix cut & paste typo. BOLT 7: gossip_query_ex typos. Sep 19, 2019
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Sep 19, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Sep 19, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@t-bast t-bast requested a review from sstone Sep 19, 2019
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Sep 19, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Sep 19, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@sstone
sstone approved these changes Sep 19, 2019
rustyrussell added a commit to rustyrussell/lightning that referenced this pull request Sep 20, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to ElementsProject/lightning that referenced this pull request Sep 22, 2019
The master spec has some typos which make it not parse, so I created
a PR and generated the CSV from that:

lightningnetwork/lightning-rfc#673

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@t-bast
t-bast approved these changes Sep 30, 2019
@t-bast

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

LGTM, merging (spelling rule).

@t-bast t-bast merged commit 3154157 into lightningnetwork:master Sep 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.