Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 2: specify that you can't send `funding_locked` until you've checked the txout #676

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@rustyrussell
Copy link
Collaborator

commented Sep 29, 2019

We might argue this does not apply if you set minimum_depth to 0, since
you're assuming trust (TurboChannels-style), but it needs to be specified.

See: CVE-2019-12998 / CVE-2019-12999 / CVE-2019-13000
Signed-off-by: Rusty Russell rusty@rustcorp.com.au

…cked the tx.

We might argue this does not apply if you set `minimum_depth` to 0, since
you're assuming trust (TurboChannels-style), but it needs to be specified.

See: CVE-2019-12998 / CVE-2019-12999 / CVE-2019-13000
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@t-bast
t-bast approved these changes Sep 30, 2019
Copy link
Collaborator

left a comment

ACK!

@t-bast t-bast added this to Scheduled in Specification Meeting Agenda Sep 30, 2019
@cdecker

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

ACK 5193fa3

Copy link
Member

left a comment

LGTM 🦑

@cdecker cdecker moved this from Scheduled to Accepted in Specification Meeting Agenda Sep 30, 2019
Copy link
Collaborator

left a comment

LGTM

@rustyrussell rustyrussell merged commit 78bc516 into lightningnetwork:master Oct 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.