Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 7: be more aggressive about sending our own gossip. #684

Merged
merged 1 commit into from Feb 3, 2020

Conversation

@rustyrussell
Copy link
Collaborator

rustyrussell commented Oct 14, 2019

As more nodes on the network use timestamp_filter to block gossip
floods, we've seen some propagation problems. This should avoid it
(and is implemented now by c-lightning).

See: ElementsProject/lightning#3152

Nodes can use `timestamp_filter` to reduce their gossip load when they
have many peers (eg. setting `first_timestamp` to 0xFFFFFFFF after the
first few peers, in the assumption that propagation is adaquate).
This assumption of adaquate propagation does not apply for gossip messages

This comment has been minimized.

Copy link
@darosior

darosior Oct 30, 2019

Contributor

adequate ?

This comment has been minimized.

Copy link
@rustyrussell

rustyrussell Nov 5, 2019

Author Collaborator

You'll have to forgive me, English is my native language...

@t-bast
t-bast approved these changes Jan 16, 2020
Copy link
Collaborator

t-bast left a comment

ACK f2e9f63, that does make sense!

t-bast added a commit to ACINQ/eclair that referenced this pull request Jan 20, 2020
This is needed to make sure we broadcast our own gossip.
Otherwise we will try to gossip at the beginning of the connection,
when the peer hasn't set any timestamp, so our gossip will be dropped.

See lightningnetwork/lightning-rfc#684
t-bast added a commit to ACINQ/eclair that referenced this pull request Jan 20, 2020
This is needed to make sure we broadcast our own gossip.
Otherwise we will try to gossip at the beginning of the connection,
when the peer hasn't set any timestamp, so our gossip will be dropped.

See lightningnetwork/lightning-rfc#684
@cdecker cdecker force-pushed the rustyrussell:gossip-push-own branch 2 times, most recently from b581724 to 9fef805 Feb 3, 2020
As more nodes on the network use timestamp_filter to block gossip
floods, we've seen some propagation problems.  This should avoid it
(and is implemented now by c-lightning).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@cdecker cdecker force-pushed the rustyrussell:gossip-push-own branch from 2977ab6 to 34612e5 Feb 3, 2020
@cdecker

This comment has been minimized.

Copy link
Collaborator

cdecker commented Feb 3, 2020

Rebased and merging this as discussed during the 2020/02/03 meeting #731.

@cdecker cdecker merged commit 458b0d3 into lightningnetwork:master Feb 3, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.