Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 7: Clarify what "gossip messages" are. #690

Open
wants to merge 1 commit into
base: master
from

Conversation

@rustyrussell
Copy link
Collaborator

rustyrussell commented Oct 30, 2019

And use that term in BOLT 2's retransmission section, to avoid confusion.

In particular: a node can't send announcement_signatures before both sides have agreed on funding_locked and thus consider the short_channel_id a settled matter.

Signed-off-by: Rusty Russell rusty@rustcorp.com.au
Fixes: #620

And use that term in BOLT 2's retransmission section, to avoid
confusion.

In particular: a node can't send `announcement_signatures` before
both sides have agreed on `funding_locked` and thus consider the
short_channel_id a settled matter.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@@ -1123,7 +1123,7 @@ operation, acknowledgments of updates are delayed until the
that the updates have been received. This also means that the receiving
node only needs to store updates upon receipt of `commitment_signed`.

Note that messages described in [BOLT #7](07-routing-gossip.md) are
Note that gossip message described in [BOLT #7](07-routing-gossip.md#gossip-messages) are

This comment has been minimized.

Copy link
@darosior

darosior Oct 30, 2019

Contributor

nit

Suggested change
Note that gossip message described in [BOLT #7](07-routing-gossip.md#gossip-messages) are
Note that gossip messages described in [BOLT #7](07-routing-gossip.md#gossip-messages) are
@cfromknecht

This comment has been minimized.

Copy link
Collaborator

cfromknecht commented Nov 1, 2019

concept ACK, this can supercede #620 as well

Copy link
Contributor

renepickhardt left a comment

I could make the PR to BOLT00 if desired.


Certain messages are used to relay information about the state of the
network, and are not merely generated to send to direct peers. We
refer to these as "gossip messages".

This comment has been minimized.

Copy link
@renepickhardt

renepickhardt Nov 5, 2019

Contributor

it might be useful to add two entries to BOLT 00 Introduction in the glossary.

  • Lightning message:

    • An encrypted message sent between connected peers.
    • Foundation of the transport layer of the communication network (defined in BOLT 08)
  • Gossip message:

    • Certain types of Lightning Messages that are forwarded to other peers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.