Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 4: add a requirement of `tlv_payload payload format` #691

Open
wants to merge 1 commit into
base: master
from

Conversation

@nayuta-gondo
Copy link
Contributor

nayuta-gondo commented Oct 30, 2019

No description provided.

Copy link
Collaborator

cfromknecht left a comment

ACK

@@ -258,6 +258,7 @@ The writer:

The reader:
- MUST return an error if `amt_to_forward` or `outgoing_cltv_value` are not present.
- MUST return an error if it is not the final node and `short_channel_id` is not present.

This comment has been minimized.

Copy link
@cfromknecht

cfromknecht Oct 30, 2019

Collaborator

should we also return an error if a node is the final hop and short_channel_id is present?

@t-bast

This comment has been minimized.

Copy link
Collaborator

t-bast commented Nov 8, 2019

ACK.
However, #643 also includes that fix. I'd rather wait for #643 to be merged instead of creating conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.