Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect legacy payload type handling implementation in BOLT #703

Open
wants to merge 2 commits into
base: master
from

Conversation

@arik-so
Copy link

arik-so commented Nov 18, 2019

In sphinx.go, legacy payloads are not given a length prefix byte.

arik-so added 2 commits Nov 18, 2019
In sphinx.go, legacy payloads are not given a length prefix byte.
Copy link
Member

Roasbeef left a comment

I think this is already covered in the "Packet Structure" section:

The length field determines both the length and the format of the hop_payload field; the following formats are defined:
Legacy hop_data format, identified by a single 0x00 byte for length. In this case the hop_payload_length is defined to be 32 bytes.

Although it may be the case that we need to make this more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.