Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBOLT 1: Define custom message type range #705
Conversation
01-messaging.md
Outdated
| @@ -66,6 +67,12 @@ A node: | |||
| - MUST fail the channels. | |||
| - that negotiates an option in this specification: | |||
| - MUST include all the fields annotated with that option. | |||
| - When defining custom messages: | |||
| - SHOULD pick a random `type` to avoid collision with other custom types. | |||
| - SHOULD pick an odd `type` identifiers when regular nodes should ignore the | |||
This comment has been minimized.
This comment has been minimized.
pm47
Nov 21, 2019
Collaborator
The it's ok to be odd rule isn't type-specific so there is no need to repeat it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
t-bast commentedNov 21, 2019
This PR defines a message type range for custom messages. The goal is to prevent unofficial messages from allocating types in the official range.
Experimentation and application-specific messages should have a way to choose "safe" message types that won't collude with a future spec-ed (official) message.