Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 1: Define custom message type range #705

Open
wants to merge 2 commits into
base: master
from

Conversation

@t-bast
Copy link
Collaborator

t-bast commented Nov 21, 2019

This PR defines a message type range for custom messages. The goal is to prevent unofficial messages from allocating types in the official range.

Experimentation and application-specific messages should have a way to choose "safe" message types that won't collude with a future spec-ed (official) message.

@t-bast t-bast requested review from pm47 and rustyrussell Nov 21, 2019
01-messaging.md Outdated Show resolved Hide resolved
@@ -66,6 +67,12 @@ A node:
- MUST fail the channels.
- that negotiates an option in this specification:
- MUST include all the fields annotated with that option.
- When defining custom messages:
- SHOULD pick a random `type` to avoid collision with other custom types.
- SHOULD pick an odd `type` identifiers when regular nodes should ignore the

This comment has been minimized.

Copy link
@pm47

pm47 Nov 21, 2019

Collaborator

The it's ok to be odd rule isn't type-specific so there is no need to repeat it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.