Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOLT 1: Define custom message type range #705

Merged
merged 1 commit into from Jan 21, 2020
Merged

Conversation

@t-bast
Copy link
Collaborator

t-bast commented Nov 21, 2019

This PR defines a message type range for custom messages. The goal is to prevent unofficial messages from allocating types in the official range.

Experimentation and application-specific messages should have a way to choose "safe" message types that won't collude with a future spec-ed (official) message.

@t-bast t-bast requested review from pm47 and rustyrussell Nov 21, 2019
01-messaging.md Outdated Show resolved Hide resolved
@@ -66,6 +67,12 @@ A node:
- MUST fail the channels.
- that negotiates an option in this specification:
- MUST include all the fields annotated with that option.
- When defining custom messages:
- SHOULD pick a random `type` to avoid collision with other custom types.
- SHOULD pick an odd `type` identifiers when regular nodes should ignore the

This comment has been minimized.

Copy link
@pm47

pm47 Nov 21, 2019

Collaborator

The it's ok to be odd rule isn't type-specific so there is no need to repeat it here.

This comment has been minimized.

Copy link
@t-bast

t-bast Dec 9, 2019

Author Collaborator

We chose to repeat it when we spec-ed the onion TLV namespace for experimentation; I did the same here for consistency but can remove it.

@cdecker

This comment has been minimized.

Copy link
Collaborator

cdecker commented Dec 9, 2019

Excellent proposal, this fits in perfectly with c-lightning's sendcustommsg RPC method and custommsg plugin hook (ElementsProject/lightning#3315) 👍

ACK dc60034

@t-bast

This comment has been minimized.

Copy link
Collaborator Author

t-bast commented Dec 9, 2019

Great, looks like we're all going in the same direction so let's make this official ;)

Copy link
Member

Roasbeef left a comment

LGTM

@ZmnSCPxj ZmnSCPxj mentioned this pull request Jan 21, 2020
@cdecker cdecker force-pushed the b01-custom-message-range branch from b606404 to 10e9a88 Jan 21, 2020
@cdecker cdecker dismissed pm47’s stale review Jan 21, 2020

Addressed by fixup.

@cdecker

This comment has been minimized.

Copy link
Collaborator

cdecker commented Jan 21, 2020

Rebased and squashed fixups.

Merging following the spec meeting on 2020/01/20

@cdecker cdecker merged commit caca437 into master Jan 21, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.