Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish sending node requirements of `update_add_htlc` #739

Closed
wants to merge 1 commit into from

Conversation

@janx
Copy link
Contributor

janx commented Feb 11, 2020

  • Remove amount_msat larger than 0 requirement because that's implied by its type u64.
  • adjust id requirements.
- Remove `amount_msat` larger than 0 requirement because that's implied by its type `u64`.
- adjust `id` requirements.
@TheBlueMatt

This comment has been minimized.

Copy link
Collaborator

TheBlueMatt commented Feb 24, 2020

No implication of > 0 is made by u64. u64s often hold a 0 value.

@janx

This comment has been minimized.

Copy link
Contributor Author

janx commented Feb 25, 2020

Right, wrongly read it as 'greater or euqal than 0'.

@janx janx closed this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.