master
Name already in use
Commits on May 19, 2023
-
Merge pull request #7668 from shaurya947/open-channel-memo
multi: accept memo note when opening channel
-
Merge pull request #7707 from ellemouton/wtclientFixes
watchtower: miscellaneous fixes
Commits on May 18, 2023
-
-
itest: update channel creation itest with Memo field logic
We test both the happy path (valid memo is returned when querying), as well as the unhappy path (invalid memo rejects the open action). To accomplish this, we update the OpenChannelParams struct inside the harness to accept the Memo.
-
rpcserver: attach channel Memo to *lnrpc.Channel struct
This allows us the memo to be returned in responses such as listchannels.
-
channeldb: persist channel Memo field and read it when fetching
We add a Memo field to the OpenChannel DB struct. We also persist it using a tlv record. We then pass the Memo value from the InitFundingReserveMsg when creating a new reservation for the channel. Finally, we also read Memo field when fetching channel from DB.
-
lnwallet: add Memo to InitFundingReserveMsg
We also pass the value of Memo from funding/manager.go.
-
funding: add Memo to InitFundingMsg struct
We add byte-array field called Memo to the InitFundingMsg struct. We also provide a value for this from rpcserver.go#parseOpenChannelReq().
-
rpcserver: enforce memo length is less than 500 characters
In this commit we ensure that the string length of the memo field specified as part of the OpenChannelRequest is no longer than 500.
-
lncli: add optional memo flag to openchannel cmd
This commit simply adds a new memo flag to the openchannel command. Memo could be any note-to-self kind of useful information to go along with the channel. The value isn't used yet, will be in the next commit.
-
lnrpc: add memo field to OpenChannelRequest and ListChannelsResponse
This commit adds the memo field to the protobuf message and generates the new go files.
-
watchtower: use a stable blob identifier
In this commit, we add an Identifier method to the blob.Type struct which returns a unique identifier for a given blob type. This identifier is then used for initialising the disk overflow queue of the given client.
-
wtclient: check un-checked errors
Some errors are not checked during startup and shutdown of the tower client. These are checked now.
Commits on May 17, 2023
-
Merge pull request #7705 from ellemouton/macStoreRootKeyReEncyption
macaroons: ensure all root keys are re-encrypted or regenerated
-
-
macaroons: let ChangePassword re-encrypt all root keys
The ChangePasswords method should re-encrypt all the root keys found in the store, not just the default root key.
-
macaroons: demo ChangePassword bug
This commits uses TestStoreChangePassword to demonstrate that currently the ChangePassword function only changes the password of the default root key and not that of other root keys. This will be fixed in an upcoming commit.
-
macaroons: Let GenerateNewRootKey be applied to all root keys
With this commit, GenerateNewRootKey will regenerate the Default root key and will then also check if any other root keys exist and regenerate those as well.
-
macaroons: demo GenerateNewRootKey bug
This commit adds to the existing TestStoreGenerateNewRootKey to show that the method only successfully regenerates the root key in the default root key ID location. This will be fixed in an upcoming commit.
Commits on May 16, 2023
-
Merge pull request #7380 from ellemouton/wtclientDiskQueue
watchtower: replace in-mem task queue with a disk over-flow queue
-
-
server+lncfg: make max in-mem tasks configurable
Add a `MaxTasksInMemQueue` field to the `WtClient` config so that users can change the default if they please.
-
-
watchtower/wtclient: generic disk overflow queue
In this commit, a new generic DiskOverflowQueue implementation is added. This allows a user to specify a maximum number of items that the queue can hold in-memory. Any new items will then overflow to disk. The producer and consumer of the queue items will interact with the queue just like a normal in-memory queue.
-
watchtower/wtmock: add in-memory impl of Queue
This commit adds an in-memory implementation of the Queue interface. This can be used for tests.
-
watchtower/wtdb: add bolt db impl of Queue
This commit adds a new generic DiskQueueDB type which is an bbolt implementation of the Queue interface.
-
-
wtclient: demo that in-mem updates are lost
This commit adds a test to the wtclient. The test demonstrates that if a client tries to back up states while it has no active sessions with a server then those updates are accumlated in memory and lost on restart. This will be fixed in upcoming commits.
Commits on May 15, 2023
Commits on May 12, 2023
-
Merge pull request #7649 from morehouse/fuzz_lnwire_signature
lnwire: signature parsing/conversion fuzz tests
-
-
lnwire: add FuzzConvertFixedSignature test
Test conversion of fixed 64-byte signatures to DER-encoded signatures.