lncfg: readd global lock for postgres and the channeldb_kv table #10394
+58
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggie1984
force-pushed
the
add-back-globallock
branch
2 times, most recently
from
660f743 to
98ea583
Compare
ziggie1984
force-pushed
the
add-back-globallock
branch
from
98ea583 to
cecc728
Compare
ziggie1984
added
postgres
size/micro
starius
approved these changes
Nov 27, 2025
Collaborator
starius
left a comment
starius
left a comment
There was a problem hiding this comment.
LGTM! 💾
Added few comments.
sqldb/config.go
Outdated
| MaxConnections int `long:"maxconnections" description:"The maximum number of open connections to the database. Set to zero for unlimited."` | ||
| SkipMigrations bool `long:"skipmigrations" description:"Skip applying migrations on startup."` | ||
| ChannelDBWithGlobalLock bool `long:"channeldb-with-global-lock" description:"Use a global lock for channeldb access. This ensures only a single writer at a time but reduces concurrency. This is a temporary workaround until the revocation log is migrated to native SQL."` | ||
| WalletDBWithGlobalLock bool `long:"walletdb-with-global-lock" description:"Use a global lock for wallet database access. This ensures only a single writer at a time but reduces concurrency. This is a temporary workaround until the wallet is fully concurrent-safe."` |
Collaborator
There was a problem hiding this comment.
Can we add default:"true" to the tags? I think lnd --help will show it then.
Collaborator
Author
There was a problem hiding this comment.
no go-flags does not support defaults for booleans.
| concurrent access, while the wallet global lock defaults to `true` to maintain | ||
| safe single-writer behavior until the wallet subsystem is fully | ||
| concurrent-safe. | ||
|
|
Collaborator
There was a problem hiding this comment.
Should we also document the options in docs/postgres.md file?
ziggie1984
force-pushed
the
add-back-globallock
branch
3 times, most recently
from
506e232 to
5b7abfd
Compare
Add two configuration options to control global lock usage for different postgres database backends: - ChannelDBWithGlobalLock: for channeldb access (default: false) - WalletDBWithGlobalLock: for wallet database access (default: true) These allow fine-grained control over which databases use global locks, rather than hardcoding the behavior. This is a temporary measure until the revocation log and wallet are migrated to native SQL and become fully concurrent-safe.
Replace hardcoded WithGlobalLock assignment with configurable options wallet postgres backends. Also add the WithGlobalLock option to the channeldb table for postgres backends. Defaults: - channeldb: false (allow concurrent access) - wallet: true (maintain safe single-writer behavior) Users can now override these defaults via: - db.postgres.channeldb-with-global-lock - db.postgres.walletdb-with-global-lock This gives operators flexibility while maintaining safe defaults until full native SQL migration is complete. Moreover exclude db.postgres.walletdb-with-global-lock check in the sample config file script. We cannot easily check the correct default because we set it later in the LND startup sequence so we exclude it.
ziggie1984
force-pushed
the
add-back-globallock
branch
from
5b7abfd to
5656335
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Postgres configuration options
db.postgres.channeldb-with-global-lockanddb.postgres.walletdb-with-global-lockto allow fine-grained control over database concurrency. The channeldb global lock defaults tofalseto enable concurrent access, while the wallet global lock defaults totrueto maintain safe single-writer behavior until the wallet subsystem is fully concurrent-safe.