Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
routing: fix route fee calculation and channel capacity check #1382
This PR fixes two problems in the routing package:
It also updates the multi hop payment integration test to cover the fee miscalculation.
referenced this pull request
Jun 15, 2018
This PR is starting to get into a rally good shape! The code makes more sense now, and it is IMO much easier to follow after your recent comment updates
I also emailed Travis to unflag your account such that we can get the tests running.
Excellent work! One worthy follow up I may add as an issue is to take advantage of the
testing.Quick package to allow us to generate a set of randomized "well formed" routes and assert certain properties against them based on path finding attempts. If we had this type of testing in place, we may have caught this bug much earlier on.
I left one minor comment w.r.t adding a comment within some fields on the newly added testing fixture just to elaborate on the meaning of a particular attribute. Other than that, LGTM
Once the fixup commits have been rebased in, we can get this one merged, then proceed with the other related PR's.