New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: restrict to forwarding only one port when using NAT traversal #1384

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@wpaulino
Collaborator

wpaulino commented Jun 13, 2018

Realized this was meant to be removed after moving the check to config.go. I've also modified this to only forward one port, as before we'd forward all the ports lnd was listening on, which would be in violation of BOLT 7's requirement of one address of each type.

@MeshCollider MeshCollider added the server label Jun 15, 2018

@wpaulino wpaulino force-pushed the wpaulino:nat-advertise-address branch from 99c3094 to 2bc9c12 Jun 20, 2018

@Roasbeef

This comment has been minimized.

Member

Roasbeef commented Jun 29, 2018

Needs rebase after the unix stuff.

@wpaulino wpaulino force-pushed the wpaulino:nat-advertise-address branch from 2bc9c12 to c2c2bed Jun 30, 2018

@wpaulino

This comment has been minimized.

Collaborator

wpaulino commented Jun 30, 2018

Rebased.

@cfromknecht

This comment has been minimized.

Collaborator

cfromknecht commented Jul 10, 2018

rebase 4 final approve?

@Roasbeef Roasbeef added the P2 label Jul 11, 2018

@wpaulino wpaulino force-pushed the wpaulino:nat-advertise-address branch from c2c2bed to 3f59a8e Jul 12, 2018

@Roasbeef Roasbeef added P3 and removed P2 labels Jul 12, 2018

@wpaulino wpaulino changed the title from server: remove unnecessary external IP address normalization to server: restrict to forwarding only one port when using NAT traversal Aug 10, 2018

wpaulino added some commits Jun 30, 2018

server: restrict to forwarding only one port when using NAT traversal
In this commit, we modify the NAT traversal's port forwarding setup to
only allow forwarding one port. We do this since BOLT #7 node
announcements require only _one_ address of each type. The existing
setup would forward and advertise every port lnd was listening on, which
would violate this requirement.

@wpaulino wpaulino force-pushed the wpaulino:nat-advertise-address branch from 3f59a8e to 95fb13e Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment