Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
routing+htlcswitch: finalize switch of CLTV delta directionality in path finding and link forwarding #1447
In this commit, we fix an old-ish bug within the project. This bug was first introduced due to an incomplete migration to the swapped directionality of the CLTV value within the
This "failure to propagate the CLTV direction swap" carried over to the
In order to fix the above bug, we've extended the
We should follow up this PR with a change to unify the hop payload generation logic across the
One last issue still linger: we don't store the min cltv delta used for a particular invoices on disk. As a result, atm, we always just use our current routing policy which is incorrect if the user ever specifies a manual final cltv value that's lower than the value of the accepting link.
Nice catch on the tests! Once this and the fee changes land, we should have a way better payment UX.