New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autopilot+config: support opening private channels with autopilot agent #1692

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
4 participants
@wpaulino
Collaborator

wpaulino commented Aug 7, 2018

No description provided.

@Roasbeef Roasbeef added this to the 0.5 milestone Aug 8, 2018

}
select {
case heuristic.moreChansResps <- resp:
wg.Done()

This comment has been minimized.

@halseth

halseth Aug 9, 2018

Collaborator

just add a defer in the beginning.

This comment has been minimized.

@wpaulino

wpaulino Aug 10, 2018

Collaborator

Fixed.

config.go Outdated
@@ -146,6 +146,7 @@ type autoPilotConfig struct {
Allocation float64 `long:"allocation" description:"The percentage of total funds that should be committed to automatic channel establishment"`
MinChannelSize int64 `long:"minchansize" description:"The smallest channel that the autopilot agent should create"`
MaxChannelSize int64 `long:"maxchansize" description:"The largest channel that the autopilot agent should create"`
Private bool `long:"private" description:"Whether the channels created by the autopilot agent should be announced to the network or not"`

This comment has been minimized.

@halseth

halseth Aug 9, 2018

Collaborator

Description states the negative of the actual flag. Could say ""Whether the channels created by the autopilot agent should be private or not. Private channels won't be announced to the network."

This comment has been minimized.

@wpaulino

wpaulino Aug 10, 2018

Collaborator

Fixed.

@wpaulino wpaulino force-pushed the wpaulino:unadvertised-autopilot branch from 0e21b3a to 6980e10 Aug 10, 2018

@cfromknecht

This comment has been minimized.

Collaborator

cfromknecht commented Aug 11, 2018

needs rebase

@wpaulino wpaulino force-pushed the wpaulino:unadvertised-autopilot branch from 6980e10 to 89325a1 Aug 11, 2018

@wpaulino

This comment has been minimized.

Collaborator

wpaulino commented Aug 11, 2018

Rebased.

@Roasbeef

Tested live and works as advertised! LGTM 🐉

@Roasbeef Roasbeef merged commit 4731e1a into lightningnetwork:master Aug 16, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 54.651%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wpaulino wpaulino deleted the wpaulino:unadvertised-autopilot branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment