Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutrino integration tests #1881

Merged
merged 13 commits into from May 27, 2019

Conversation

@halseth
Copy link
Collaborator

@halseth halseth commented Sep 11, 2018

This PR enables integration tests for Neutrino. It us currently blocked by a number of other PRs, but putting it put to make Travis comfortable with this new node type.

Blocked by:

@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from b6f4aa7 to 8560366 Sep 12, 2018
@halseth halseth added this to the 0.5.1 milestone Sep 19, 2018
@halseth halseth removed this from the 0.5.1 milestone Sep 20, 2018
@halseth halseth added this to the 0.5.2 milestone Sep 20, 2018
@halseth halseth force-pushed the neutrino-integration-tests branch from 8560366 to 168ea16 Oct 19, 2018
@halseth halseth added P3 and removed P2 labels Nov 2, 2018
@wpaulino wpaulino self-requested a review Dec 20, 2018
@Roasbeef Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019
@wpaulino wpaulino added this to the 0.6 milestone Jan 16, 2019
@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Jan 16, 2019

App dependents merged, this can now be revived!

@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from 92932b4 to 830925c Feb 5, 2019
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 1de70f1 to e26255f Feb 7, 2019
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 0fbbbe6 to 08c7fc3 Feb 20, 2019
@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from 6b47f1d to ae38e83 May 21, 2019
lntest/node.go Show resolved Hide resolved
lntest/btcd.go Show resolved Hide resolved
make/testing_flags.mk Outdated Show resolved Hide resolved
lnd_test.go Outdated Show resolved Hide resolved
lnd_test.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
discovery/sync_manager.go Outdated Show resolved Hide resolved
make/testing_flags.mk Show resolved Hide resolved
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 33620b3 to c7c297f May 24, 2019
@halseth
Copy link
Collaborator Author

@halseth halseth commented May 24, 2019

Dependency merged, and comments addressed. PTAl @wpaulino

Copy link
Collaborator

@wpaulino wpaulino left a comment

LGTM 🧪

Glad to finally have these out. Needs one last rebase now that the Neutrino dependency update has been merged.

@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented May 25, 2019

Ready to land after a rebase that removes the first commit!

halseth added 13 commits May 27, 2019
This commit gives the current chainbackend the ability to connect and
disconnect the chain backend at will. We do this to let the chain
backend initiate the connection to the miner, not the other way around.

This is a preparation for using Neutrino as a backend, as it only allows
making outbound connections.

We must also move the setup of the chainbackend to after to miner, to
know the address to connect to.
Defaults to running itests with btcd.
We slightly alter testUnconfirmedChannelFunding to instead of using an
external deposit to test unconfirmed channel funding, we use one of our
own unconfirmed change outputs.

This is done since Neutrino currently has now way of knowing about
incoming unconfirmed outputs.
Needed for neutrino itest on darwin.
@halseth halseth force-pushed the neutrino-integration-tests branch from c7c297f to 34032ef May 27, 2019
@halseth
Copy link
Collaborator Author

@halseth halseth commented May 27, 2019

Rebased.

}

// NewBackend starts and returns a NeutrinoBackendConfig for the node.
func NewBackend(miner string) (*NeutrinoBackendConfig, func(), error) {
Copy link
Member

@Roasbeef Roasbeef May 27, 2019

Nice usage of the build tag here!

Copy link
Member

@Roasbeef Roasbeef left a comment

LGTM 👒

@Roasbeef Roasbeef merged commit 3b57546 into lightningnetwork:master May 27, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants