Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutrino integration tests #1881

Merged
merged 13 commits into from May 27, 2019

Conversation

Projects
None yet
3 participants
@halseth
Copy link
Collaborator

commented Sep 11, 2018

This PR enables integration tests for Neutrino. It us currently blocked by a number of other PRs, but putting it put to make Travis comfortable with this new node type.

Blocked by:

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch 2 times, most recently from b6f4aa7 to 8560366 Sep 12, 2018

@halseth halseth modified the milestones: 0.5.1, 0.5.2 Sep 19, 2018

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch from 8560366 to 168ea16 Oct 19, 2018

@halseth halseth added P3 and removed P2 labels Nov 2, 2018

@wpaulino wpaulino self-requested a review Dec 20, 2018

@Roasbeef Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019

@wpaulino wpaulino added this to the 0.6 milestone Jan 16, 2019

@Roasbeef

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

App dependents merged, this can now be revived!

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch 2 times, most recently from 92932b4 to 830925c Jan 30, 2019

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch 6 times, most recently from 1de70f1 to e26255f Feb 6, 2019

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch 6 times, most recently from 0fbbbe6 to 08c7fc3 Feb 19, 2019

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch from 6b47f1d to ae38e83 May 21, 2019

Show resolved Hide resolved lntest/node.go
Show resolved Hide resolved lntest/btcd.go
Show resolved Hide resolved make/testing_flags.mk Outdated
Show resolved Hide resolved lnd_test.go Outdated
Show resolved Hide resolved lnd_test.go
Show resolved Hide resolved Makefile Outdated
Show resolved Hide resolved discovery/sync_manager.go Outdated
Show resolved Hide resolved make/testing_flags.mk

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch 6 times, most recently from 33620b3 to c7c297f May 24, 2019

@halseth

This comment has been minimized.

Copy link
Collaborator Author

commented May 24, 2019

Dependency merged, and comments addressed. PTAl @wpaulino

@wpaulino
Copy link
Collaborator

left a comment

LGTM 🧪

Glad to finally have these out. Needs one last rebase now that the Neutrino dependency update has been merged.

@Roasbeef

This comment has been minimized.

Copy link
Member

commented May 25, 2019

Ready to land after a rebase that removes the first commit!

halseth added some commits May 24, 2019

lnd_test: alter testUnconfirmedChannelFunding to work with Neutrino
We slightly alter testUnconfirmedChannelFunding to instead of using an
external deposit to test unconfirmed channel funding, we use one of our
own unconfirmed change outputs.

This is done since Neutrino currently has now way of knowing about
incoming unconfirmed outputs.
make: add backend tag for itests
Defaults to running itests with btcd.
lntest+lnd_test: add Connect and Disconnect miner for BackendCfgs
This commit gives the current chainbackend the ability to connect and
disconnect the chain backend at will. We do this to let the chain
backend initiate the connection to the miner, not the other way around.

This is a preparation for using Neutrino as a backend, as it only allows
making outbound connections.

We must also move the setup of the chainbackend to after to miner, to
know the address to connect to.
make: increase itest timeout to 40 min
Needed for neutrino itest on darwin.

@halseth halseth force-pushed the halseth:neutrino-integration-tests branch from c7c297f to 34032ef May 27, 2019

@halseth

This comment has been minimized.

Copy link
Collaborator Author

commented May 27, 2019

Rebased.

}

// NewBackend starts and returns a NeutrinoBackendConfig for the node.
func NewBackend(miner string) (*NeutrinoBackendConfig, func(), error) {

This comment has been minimized.

Copy link
@Roasbeef

Roasbeef May 27, 2019

Member

Nice usage of the build tag here!

@Roasbeef
Copy link
Member

left a comment

LGTM 👒

@Roasbeef Roasbeef merged commit 3b57546 into lightningnetwork:master May 27, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.003%) to 60.581%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.