Neutrino integration tests #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
neutrino-integration-tests
branch
2 times, most recently
from
b6f4aa7 to
8560366
Compare
Roasbeef
added
P2
halseth
force-pushed
the
neutrino-integration-tests
branch
from
8560366 to
168ea16
Compare
halseth
added
P3
Member
|
App dependents merged, this can now be revived! |
halseth
force-pushed
the
neutrino-integration-tests
branch
2 times, most recently
from
92932b4 to
830925c
Compare
halseth
force-pushed
the
neutrino-integration-tests
branch
6 times, most recently
from
1de70f1 to
e26255f
Compare
halseth
force-pushed
the
neutrino-integration-tests
branch
6 times, most recently
from
0fbbbe6 to
08c7fc3
Compare
halseth
force-pushed
the
neutrino-integration-tests
branch
2 times, most recently
from
6b47f1d to
ae38e83
Compare
wpaulino
reviewed
May 21, 2019
halseth
force-pushed
the
neutrino-integration-tests
branch
6 times, most recently
from
33620b3 to
c7c297f
Compare
Contributor
Author
|
Dependency merged, and comments addressed. PTAl @wpaulino |
wpaulino
approved these changes
May 24, 2019
Contributor
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
LGTM 🧪
Glad to finally have these out. Needs one last rebase now that the Neutrino dependency update has been merged.
Member
|
Ready to land after a rebase that removes the first commit! |
This commit gives the current chainbackend the ability to connect and disconnect the chain backend at will. We do this to let the chain backend initiate the connection to the miner, not the other way around. This is a preparation for using Neutrino as a backend, as it only allows making outbound connections. We must also move the setup of the chainbackend to after to miner, to know the address to connect to.
Defaults to running itests with btcd.
We slightly alter testUnconfirmedChannelFunding to instead of using an external deposit to test unconfirmed channel funding, we use one of our own unconfirmed change outputs. This is done since Neutrino currently has now way of knowing about incoming unconfirmed outputs.
Needed for neutrino itest on darwin.
halseth
force-pushed
the
neutrino-integration-tests
branch
from
c7c297f to
34032ef
Compare
Contributor
Author
|
Rebased. |
Roasbeef
reviewed
May 27, 2019
| } | ||
|
|
||
| // NewBackend starts and returns a NeutrinoBackendConfig for the node. | ||
| func NewBackend(miner string) (*NeutrinoBackendConfig, func(), error) { |
Member
There was a problem hiding this comment.
Nice usage of the build tag here!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables integration tests for Neutrino. It us currently blocked by a number of other PRs, but putting it put to make Travis comfortable with this new node type.
Blocked by: