Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutrino integration tests #1881

Merged
merged 13 commits into from
May 27, 2019

Conversation

@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from b6f4aa7 to 8560366 Compare September 12, 2018 07:05
@Roasbeef Roasbeef added P2 should be fixed if one has time tests needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet labels Sep 14, 2018
@halseth halseth modified the milestones: 0.5.1, 0.5.2 Sep 19, 2018
@halseth halseth added P3 might get fixed, nice to have and removed P2 should be fixed if one has time labels Nov 2, 2018
@wpaulino wpaulino self-requested a review December 20, 2018 20:13
@Roasbeef Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019
@wpaulino wpaulino added this to the 0.6 milestone Jan 16, 2019
@Roasbeef
Copy link
Member

App dependents merged, this can now be revived!

@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from 92932b4 to 830925c Compare February 5, 2019 10:05
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 1de70f1 to e26255f Compare February 7, 2019 10:26
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 0fbbbe6 to 08c7fc3 Compare February 20, 2019 12:13
@halseth halseth force-pushed the neutrino-integration-tests branch 2 times, most recently from 6b47f1d to ae38e83 Compare May 21, 2019 11:48
lntest/node.go Show resolved Hide resolved
lntest/btcd.go Show resolved Hide resolved
make/testing_flags.mk Outdated Show resolved Hide resolved
lnd_test.go Outdated Show resolved Hide resolved
lnd_test.go Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
discovery/sync_manager.go Outdated Show resolved Hide resolved
make/testing_flags.mk Show resolved Hide resolved
@halseth halseth force-pushed the neutrino-integration-tests branch 6 times, most recently from 33620b3 to c7c297f Compare May 24, 2019 12:18
@halseth
Copy link
Contributor Author

halseth commented May 24, 2019

Dependency merged, and comments addressed. PTAl @wpaulino

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧪

Glad to finally have these out. Needs one last rebase now that the Neutrino dependency update has been merged.

@Roasbeef
Copy link
Member

Ready to land after a rebase that removes the first commit!

halseth added 13 commits May 27, 2019 09:29
This commit gives the current chainbackend the ability to connect and
disconnect the chain backend at will. We do this to let the chain
backend initiate the connection to the miner, not the other way around.

This is a preparation for using Neutrino as a backend, as it only allows
making outbound connections.

We must also move the setup of the chainbackend to after to miner, to
know the address to connect to.
Defaults to running itests with btcd.
We slightly alter testUnconfirmedChannelFunding to instead of using an
external deposit to test unconfirmed channel funding, we use one of our
own unconfirmed change outputs.

This is done since Neutrino currently has now way of knowing about
incoming unconfirmed outputs.
Needed for neutrino itest on darwin.
@halseth halseth force-pushed the neutrino-integration-tests branch from c7c297f to 34032ef Compare May 27, 2019 07:29
@halseth
Copy link
Contributor Author

halseth commented May 27, 2019

Rebased.

}

// NewBackend starts and returns a NeutrinoBackendConfig for the node.
func NewBackend(miner string) (*NeutrinoBackendConfig, func(), error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of the build tag here!

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👒

@Roasbeef Roasbeef merged commit 3b57546 into lightningnetwork:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet P3 might get fixed, nice to have tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants