New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value_sat and value_msat to Payment #1922

Merged
merged 2 commits into from Sep 28, 2018

Conversation

Projects
None yet
5 participants
@roeierez
Contributor

roeierez commented Sep 16, 2018

This PR is following PR #1855
In addition to that change in invoice response I believe the same convention is needed in outgoing payments to remove confusion and for consistency.
This PR also maintains backward compatibility by leaving and deprecating the current "Value" field.

@cfromknecht

@roeierez makes sense to me! Mirroring the changes made to invoices, can you mark value with deprecated=true similar to #1855

Also if the comment could begin with "Deprecated", that will propagate to api.lightning.community!

@roeierez

This comment has been minimized.

Contributor

roeierez commented Sep 18, 2018

Done!

@halseth

This comment has been minimized.

Collaborator

halseth commented Sep 18, 2018

The two proto changes should be squashed together (and regenerated), otherwise LGTM!

@roeierez roeierez force-pushed the roeierez:payments_rpc branch from d99b637 to 9c59096 Sep 18, 2018

@roeierez

This comment has been minimized.

Contributor

roeierez commented Sep 18, 2018

Squashed.

@halseth

This comment has been minimized.

Collaborator

halseth commented Sep 19, 2018

Needs a rebase to remove the merge branch master commit.

@halseth halseth added this to the 0.5.1 milestone Sep 19, 2018

@roeierez roeierez force-pushed the roeierez:payments_rpc branch from e1ec213 to 9c59096 Sep 20, 2018

@roeierez

This comment has been minimized.

Contributor

roeierez commented Sep 20, 2018

Removed

@halseth

This comment has been minimized.

Collaborator

halseth commented Sep 24, 2018

Needs a rebase to fix the proto conflict.

@cfromknecht

This comment has been minimized.

Collaborator

cfromknecht commented Sep 24, 2018

Yep changes look good to me, rebase should be the last step

@roeierez roeierez force-pushed the roeierez:payments_rpc branch from 9c59096 to 06bce1c Sep 25, 2018

@roeierez

This comment has been minimized.

Contributor

roeierez commented Sep 25, 2018

Rebased

"value_sat": {
"type": "string",
"format": "int64",
"title": "/ The value of the payment in satoshies"

This comment has been minimized.

@flack

flack Sep 25, 2018

Typo: satoshies

@roeierez roeierez force-pushed the roeierez:payments_rpc branch from 06bce1c to 6bc0138 Sep 27, 2018

@roeierez

This comment has been minimized.

Contributor

roeierez commented Sep 27, 2018

fixed typo

@Roasbeef

LGTM 👾

@Roasbeef Roasbeef merged commit 54deb00 into lightningnetwork:master Sep 28, 2018

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.007%) to 53.897%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment