Join GitHub today
rpc+server: ensure we don't leak unadvertised nodes within invoice routing hints #1981
In this commit, we ensure that we don't include routing hints for
Nice! This patches a lingering hole w.r.t our handling of non-advertised channels for invoices. The second hole will be patched once we stop showing non-advertised channels by default in the output of
describegraph. I have no major comments other than possibly , puling in the new method into the
channeldb package, rather than having tacking on a totally unrelated method to the server struct. Generally we should stop adding these utility methods/functions to the server, as we need to get rid of the "God Pointer" pattern, and properly abstract the messaging passing between sub-systems via interfaces. Also pulling this method into the
LightningNode struct itself will allow us to effectively unit test it.