Server: make maximum backoff configurable #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccdle12
reviewed
Oct 4, 2018
halseth
added
config
|
Needs a rebase! |
|
Rebased. |
wpaulino
previously approved these changes
Dec 6, 2018
|
Could you squash the commits into one as well? |
cfromknecht
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
LGTM!
Another thing that would help wrt to mobile is to have a configurable defaultStableConnDuration. This parameter specifies that if a connection lasts shorter than this duration, we will always try to back it off. The current value is 10 minutes, which might be too long on mobile. That would also make a good candidate for a follow up if you're interested :)
https://github.com/lightningnetwork/lnd/blob/master/server.go#L63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of spotty wifi coverage a mobile device will rapidly switch from wifi to 4G and vice versa. In these cases the persistent peer will disconnect and the backoff period will increase exponentially. After a couple reconnects we are talking about minutes which makes for bad user experience.