Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate own node announcement, signature length #2030

Merged
merged 2 commits into from Dec 6, 2018
Merged

Validate own node announcement, signature length #2030

merged 2 commits into from Dec 6, 2018

Conversation

halseth
Copy link
Contributor

@halseth halseth commented Oct 10, 2018 •
edited

To avoid inserting invalid signatures into the DB.

Maybe maybe fixes #2016

@halseth halseth mentioned this pull request Oct 10, 2018
Closed
@halseth halseth changed the title [WIP | DO NOT REVIEW] Authsig len Validate own node announcement, signature length Dec 5, 2018
@halseth
Copy link
Contributor Author

halseth commented Dec 5, 2018

Candidate for a "clean–my-db" migration.

@halseth halseth added database Related to the database/storage of LND P2 should be fixed if one has time gossip labels Dec 5, 2018
cfromknecht
cfromknecht approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

wpaulino
wpaulino approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎱

@Roasbeef Roasbeef merged commit 1d1e9f2 into lightningnetwork:master Dec 6, 2018
@fluidvoice fluidvoice mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfromknecht cfromknecht cfromknecht approved these changes

@wpaulino wpaulino wpaulino approved these changes

Assignees
No one assigned
Labels
database Related to the database/storage of LND gossip P2 should be fixed if one has time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SRVR: unable to create server: can't create router: ReadVarBytes: sig is larger than the max allowed size
4 participants
@halseth @cfromknecht @wpaulino @Roasbeef