Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
chainntnfs: re-enable height hint cache #2044
Ready for review! There are some additional commits (might seem unrelated) that solve some integration test flakes due to timing issues upon re-enabling the height hint cache.
One thing that's left to address, which was brought up by @cfromknecht, is whether we want to clear the existing state of users' caches. I believe this won't be needed in the case that users have successfully started up after the cache was disabled, as a rescan will occur from the broadcast height and catch everything since then. If this hasn't happened however, it's possible that they begin their rescan after the fact due to previous incorrect behavior of the cache.
3 times, most recently
Oct 20, 2018
referenced this pull request
Oct 25, 2018
There shouldn't be any issues with the integration tests other than:
I don't think we need to worry about clearing any existing caches, as it was never included in a major release. Additionally, any entries that users had in their caches are now long expired since many weeks have passed since the initial implementation, and the commit that disabled all the caches. The users that had prior height hints also in a way will benefit from them as they won't need to start from the initial broadcast (or confirm or w/e height) and can start a bit earlier in the chain.