Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add litecoin regtest to lnd #2189

Merged

Conversation

@dannypaz
Copy link
Contributor

@dannypaz dannypaz commented Nov 15, 2018

This PR enables regtest mode for ltcd/litecoind in lnd.

Related PRs:
ltcsuite/ltcd#10 was recently merged into LTCD to prevent failures of invalid genesis block.
LTCD archived the issue here: ltcsuite-archive/ltcd#10

Changes include:

  1. Updating LTCD version in lnd
  2. Adding regtest configuration to config.go
  3. renaming regtestNetParams to bitcoinRegTestNetParams
@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Nov 29, 2018

Dupe of #1996 however additional changes were made

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from ef2108c to c1958a8 Nov 29, 2018
@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Nov 30, 2018

@Roasbeef et.al, I reviewed adding specs and most of this code is untested. Is there anything else that needs to be done to get this PR merged?

@ecurrencyhodler
Copy link

@ecurrencyhodler ecurrencyhodler commented Dec 5, 2018

Bump

@halseth
Copy link
Collaborator

@halseth halseth commented Dec 11, 2018

Related: #1865

@halseth halseth requested a review from cfromknecht Dec 11, 2018
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM! 🎉

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Jan 11, 2019

needs a rebase on master first tho

@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Jan 11, 2019

@cfromknecht thanks for the review. We are rebased

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from 9d36d60 to 70aff1e Jan 17, 2019
@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Jan 17, 2019

@cfromknecht please re-review before merge

Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM 🎊

@jlamur
Copy link
Contributor

@jlamur jlamur commented Feb 6, 2019

The LTCD repo was destroyed and recreated for whatever reason… In consequence, the commit history wasn't preserved, and my PR ensuring ltcd / litecoind regtest compatibility was probably trashed (I don't have the time to check). (edit: this one: ltcsuite/ltcd#10)

BTW, the diff of go.sum seems weird (lot of deleted lines not related to this PR), please double check that.

@dannypaz you should also fix your author / commiter emails in your commit.

@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Feb 6, 2019

@jlamur I got your PR ltcsuite-archive/ltcd#10 (ltcd was pushed to the archive) merged to master before they did the upgrade. Thanks for letting me know about the author/commit github stuff.

@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Feb 6, 2019

@cfromknecht you'll need to re-review

@jlamur
Copy link
Contributor

@jlamur jlamur commented Feb 16, 2019

I got your PR ltcsuite-archive/ltcd#10 (ltcd was pushed to the archive) merged to master before they did the upgrade.

Well it got merged on the archived repository only. The brand new one does contain neither my commit nor my changes.

Ignore that, I was wrong, the changes were squashed in the commit ltcsuite/ltcd@5f2d96f.

jlamur
jlamur approved these changes Feb 17, 2019
Copy link
Contributor

@jlamur jlamur left a comment

LGTM

Copy link
Collaborator

@halseth halseth left a comment

utACK 👍

@cfromknecht cfromknecht added this to the 0.6.1 milestone Apr 12, 2019
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM 🚀

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Apr 19, 2019

@dannypaz needs rebase now that #1865 is in

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Apr 27, 2019

@dannypaz if you're busy atm we can push this off to 0.7

@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from ef6690d to 5079335 Apr 27, 2019
regtest change to chainregistry for default port number

merge w/ master
@dannypaz dannypaz force-pushed the sparkswap/litecoin-regtest branch from 5079335 to 6fd5ef8 Apr 27, 2019
@dannypaz
Copy link
Contributor Author

@dannypaz dannypaz commented Apr 27, 2019

@cfromknecht sorry about that. thanks for letting me know. we are rebased

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Apr 27, 2019

@dannypaz no worries just thought I’d leave a reminder :)

@cfromknecht cfromknecht merged commit 517cdd6 into lightningnetwork:master Apr 29, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants