Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: update release script to allow user to specify systems #2191

Merged
merged 1 commit into from Dec 18, 2018

Conversation

@xsb
Copy link
Contributor

@xsb xsb commented Nov 16, 2018

Whenever there is a new tagged release I find it useful to use release.sh targeting my own architecture. This PR introduces the option to specify a subset of systems/architectures or to try experimental ones without editing it.

Example:

LNDBUILDSYS="linux-arm64 darwin-amd64" ./release.sh

Notice that this is totally optional. When LNDBUILDSYS is unset the script works as always did.

@halseth
Copy link
Collaborator

@halseth halseth commented Nov 23, 2018

Concept ACK

Copy link
Member

@Roasbeef Roasbeef left a comment

Tested locally, LGTM 🎉

@Roasbeef Roasbeef merged commit e028355 into lightningnetwork:master Dec 18, 2018
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.02%) to 56.021%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Roasbeef Roasbeef added this to In progress in High Priority via automation Dec 18, 2018
@Roasbeef Roasbeef moved this from In progress to Done in High Priority Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
High Priority
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants