Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: add channels to GetNodeInfo response #2308

Merged
merged 1 commit into from May 24, 2019

Conversation

@chokoboko
Copy link
Contributor

@chokoboko chokoboko commented Dec 10, 2018

This PR adds an array of ChannelEdges to GetNodeInfo response, with json_name "channels"

fixes #2287

Copy link
Collaborator

@halseth halseth left a comment

Pretty much looks good. Needs a rebase!

rpcserver.go Outdated Show resolved Hide resolved
rpcserver.go Outdated Show resolved Hide resolved
@chokoboko chokoboko force-pushed the channels-in-getnodeinfo branch from ac62fe4 to 0292610 May 9, 2019
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

@chokoboko super stoked to finally have this feature!! some minor comments left in line, also will need a rebase

rpcserver.go Outdated Show resolved Hide resolved
lnrpc/rpc.proto Show resolved Hide resolved
@chokoboko chokoboko force-pushed the channels-in-getnodeinfo branch from 0292610 to e47e65f May 22, 2019
@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented May 23, 2019

Thanks for the quick turnaround @chokoboko. IMO this is good to go, but it will conflict with #2312. To save everyone from extra rebases, I’ll ping once that’s landed so you can rebase on master and we can get a clean Travis run with the latest build fixes

@halseth
Copy link
Collaborator

@halseth halseth commented May 23, 2019

@chokoboko can now be rebased! :)

@chokoboko chokoboko force-pushed the channels-in-getnodeinfo branch from e47e65f to 51dc422 May 23, 2019
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM!! 🍸

Copy link
Collaborator

@wpaulino wpaulino left a comment

LGTM 🥊

@Roasbeef Roasbeef merged commit 50f0ac5 into lightningnetwork:master May 24, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants