Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: add channels to GetNodeInfo response #2308

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
5 participants
@chokoboko
Copy link
Contributor

commented Dec 10, 2018

This PR adds an array of ChannelEdges to GetNodeInfo response, with json_name "channels"

fixes #2287

@Roasbeef Roasbeef requested a review from halseth Dec 10, 2018

@cfromknecht cfromknecht added this to the 0.7 milestone Apr 11, 2019

@halseth
Copy link
Collaborator

left a comment

Pretty much looks good. Needs a rebase!

Show resolved Hide resolved rpcserver.go Outdated
Show resolved Hide resolved rpcserver.go Outdated

@chokoboko chokoboko force-pushed the chokoboko:channels-in-getnodeinfo branch from ac62fe4 to 0292610 May 9, 2019

@cfromknecht
Copy link
Collaborator

left a comment

@chokoboko super stoked to finally have this feature!! some minor comments left in line, also will need a rebase

Show resolved Hide resolved rpcserver.go Outdated
Show resolved Hide resolved lnrpc/rpc.proto

@chokoboko chokoboko force-pushed the chokoboko:channels-in-getnodeinfo branch from 0292610 to e47e65f May 22, 2019

@cfromknecht

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

Thanks for the quick turnaround @chokoboko. IMO this is good to go, but it will conflict with #2312. To save everyone from extra rebases, I’ll ping once that’s landed so you can rebase on master and we can get a clean Travis run with the latest build fixes

@halseth

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

@chokoboko can now be rebased! :)

@chokoboko chokoboko force-pushed the chokoboko:channels-in-getnodeinfo branch from e47e65f to 51dc422 May 23, 2019

@cfromknecht
Copy link
Collaborator

left a comment

LGTM!! 🍸

@wpaulino
Copy link
Collaborator

left a comment

LGTM 🥊

@Roasbeef Roasbeef merged commit 50f0ac5 into lightningnetwork:master May 24, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on channels-in-getnodeinfo at 60.312%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.