rpcserver: add channels to GetNodeInfo response#2308
Merged
Roasbeef merged 1 commit intolightningnetwork:masterfrom May 24, 2019
Merged
rpcserver: add channels to GetNodeInfo response#2308Roasbeef merged 1 commit intolightningnetwork:masterfrom
Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
Roasbeef
added
enhancement
halseth
suggested changes
May 9, 2019
Contributor
halseth
left a comment
halseth
left a comment
There was a problem hiding this comment.
Pretty much looks good. Needs a rebase!
chokoboko
force-pushed
the
channels-in-getnodeinfo
branch
from
ac62fe4 to
0292610
Compare
cfromknecht
reviewed
May 22, 2019
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
@chokoboko super stoked to finally have this feature!! some minor comments left in line, also will need a rebase
chokoboko
force-pushed
the
channels-in-getnodeinfo
branch
from
0292610 to
e47e65f
Compare
Contributor
|
Thanks for the quick turnaround @chokoboko. IMO this is good to go, but it will conflict with #2312. To save everyone from extra rebases, I’ll ping once that’s landed so you can rebase on master and we can get a clean Travis run with the latest build fixes |
Contributor
|
@chokoboko can now be rebased! :) |
chokoboko
force-pushed
the
channels-in-getnodeinfo
branch
from
e47e65f to
51dc422
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an array of ChannelEdges to GetNodeInfo response, with json_name "channels"
fixes #2287