Skip to content

rpc: add node color to NodeUpdate and GetInfo #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halseth merged 4 commits into from
May 23, 2019
Merged

rpc: add node color to NodeUpdate and GetInfo #2312

halseth merged 4 commits into from
May 23, 2019

Conversation

@xsb
Copy link
Contributor

@xsb xsb commented Dec 10, 2018

This adds the node color to both NodeUpdate (as part of aGraphTopologyUpdate) and to GetInfo response. Tested with a Go gRPC client.

Fixes #2255 and #2268

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour gRPC needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet labels Dec 11, 2018
halseth
halseth reviewed Dec 11, 2018
View reviewed changes
halseth
halseth reviewed Dec 13, 2018
View reviewed changes
routing/notifications.go Outdated
Copy link
Contributor

@halseth halseth Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is needed here, really. If you want to inspect the color you can use the GetNodeInfo RPC.

Copy link
Contributor Author

@xsb xsb Dec 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to implement #2255

Copy link
Contributor

@halseth halseth Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Ideally, the encode method would be shared, and not duplicated across the two packages though...

halseth
halseth suggested changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, independent changes for different packages should be in separate commits. In this case I would suggest lnrpc, server+server_test, rpcserver and finally lncli commits, in that order.

server.go Outdated
Copy link
Contributor

@halseth halseth Dec 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with this addition, the server_test.go should be expended to test this!

@xsb
Copy link
Contributor Author

xsb commented Dec 21, 2018

@halseth I made it with a separate commit per package as you suggested and also added a test. Something I am not convinced though is exposing the utility method EncodeHexColor from the routing package but I wasn't sure where to put it. Seems weird to me, I am open to changes.

halseth
halseth approved these changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not obvious where to put it, but I think routing is alright for now. LGTM 👍

@xsb
Copy link
Contributor Author

xsb commented Mar 15, 2019

Rebased

@halseth halseth added the P3 might get fixed, nice to have label Mar 19, 2019
@cfromknecht cfromknecht added this to the 0.7 milestone Apr 11, 2019
halseth
halseth suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase and proto regen

@xsb
Copy link
Contributor Author

xsb commented May 10, 2019

@halseth rebased with latest master + proto files regenerated

@cfromknecht
Copy link
Contributor

cfromknecht commented May 14, 2019

@xsb looks like we have another conflict 😶

@xsb
Copy link
Contributor Author

xsb commented May 16, 2019

@halseth @cfromknecht Rebased again.

Note: While regenerating the proto files I got a different result for lnrpc/invoicesrpc/invoices.pb.go that I ignored it for the sake of cleanliness. It seems to come from the recently merged #3019. Either the author of that PR or myself are not running the correct protoc, etc. Probably not super important but better to clarify before merging this.

@cfromknecht cfromknecht mentioned this pull request May 17, 2019
Closed
cfromknecht
cfromknecht approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xsb LGTM! 🎉 Thank you for pointing out the versioning mismatch in the protos, I've created an issue to avoid this in the future, see #3094

@cfromknecht cfromknecht requested a review from halseth May 22, 2019 05:31
@halseth
Copy link
Contributor

halseth commented May 22, 2019

Yet another proto conflict 🤕

Note: While regenerating the proto files I got a different result for lnrpc/invoicesrpc/invoices.pb.go that I ignored it for the sake of cleanliness.

If you still see this after rebasing on master, check your proto+tools version. I just tried rebasing this on master, and regenerating the protos doesn't create any changes to that file for me.

@xsb
Copy link
Contributor Author

xsb commented May 22, 2019

@halseth rebased again. No issue regenerating protos this time (tried on master and on my branch).

@cfromknecht
Copy link
Contributor

cfromknecht commented May 23, 2019

sorry @xsb, there was a conflict w/ #3082 :/ you'll need to rebase on master and ensure that your protogen version is on 0.1.3 (step 2 of https://github.com/lightningnetwork/lnd/tree/master/lnrpc#generate-protobuf-definitions)

Feel free to ping me when you're ready, hoping to minimize the number of rebases on your end 😬

@xsb
Copy link
Contributor Author

xsb commented May 23, 2019

@cfromknecht rebased again after upgrading to new protobuf version

@cfromknecht cfromknecht mentioned this pull request May 23, 2019
Merged
@halseth halseth merged commit 6cd71b7 into lightningnetwork:master May 23, 2019
@halseth halseth mentioned this pull request May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@cfromknecht cfromknecht cfromknecht approved these changes

@halseth halseth halseth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvements to existing features / behaviour gRPC needs review PR needs review by regular contributors needs testing PR hasn't yet been actively tested on testnet/mainnet P3 might get fixed, nice to have

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

Return node color changes in subscribe channel graph graph topology updates

4 participants

@xsb @cfromknecht @halseth @Roasbeef