Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: configurable min backoff #2417

Merged
merged 2 commits into from Jan 8, 2019
Merged

Conversation

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Jan 4, 2019

This PR adds a --minbackoff configuration option, which allows one to specify the minimum backoff used when reconnecting to persistent peers. The current value is hard coded at 1 second, which remains the default configuration.

This is useful in integration tests that depend on reliably disconnecting peers, and testing behaviors in the absence of a successful reconnection. We can simulate this even by now setting the min back off to a reasonably high value, such as to not interfere with the tests.

Prepration for #2411

Copy link
Collaborator

@wpaulino wpaulino left a comment

LGTM 🗿

@halseth
halseth approved these changes Jan 8, 2019
Copy link
Collaborator

@halseth halseth left a comment

LGTM 💯

@halseth halseth merged commit 3ab0189 into lightningnetwork:master Jan 8, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.01%) to 55.89%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cfromknecht cfromknecht deleted the cfromknecht:min-backoff branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants