Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnwallet: Add keyring and remote CSV delay to BreachRetribution #2431

Merged

Conversation

Projects
None yet
2 participants
@cfromknecht
Copy link
Collaborator

cfromknecht commented Jan 8, 2019

This PR modifies lnwallet.BreachRetribution to expose the remote CSV and commitment key ring.
This information is currently only accessible from the existing interface by manually parsing the scripts in the sign descriptors, which is cumbersome and error prone. In addition, we fix an existing issue wrt to not nilling curves before spewing in the cnct, which show up on trace.

In the context of the watchtower client, the RemoteDelay, DelayKey, NoDelayKey and RevocationKey are to be readily embedded in the justice kits sent to the watchtowers.

cfromknecht added some commits Dec 20, 2018

@Roasbeef Roasbeef requested a review from halseth Jan 9, 2019

@Roasbeef
Copy link
Member

Roasbeef left a comment

LGTM 💥

@Roasbeef Roasbeef merged commit 400a1d3 into lightningnetwork:master Jan 11, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 56.178%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.