server: require the DLP bit for all incoming/outgoing connections #2500
Conversation
In this commit, we modify our default local feature bits to require the Data Loss Protection (DLP) feature to be active. Once full Static Channel Backups are implemented, if we connect to a peer that doesn't follow the DLP protocol, then the SCBs are useless, as we may not be able to recover funds. As a result, in prep for full SCB deployment, we'll now ensure that any peer we connect to, knows of the DLP bit. This could be a bit more relaxed and allow _connections_ to non-DLP peers, but reject channel requests to/from them. However, this implementation is much simpler.
|
We also need to modify |
Roasbeef
added
safety
|
Pushed up a commit to now disconnect the peers that don't have this new feature bit. Before we merge this, I want to refactor this area to be a bit more general so we have a single place in the |
|
@Roasbeef are you still planning to the refactoring here? |
|
Ideally yes. If y'all don't consider it a blocker, then we can have this land now, and I can follow up with a refactor+tests. |
|
I think that this merge has some issues, my node cannot bootstrap connections saying "unable to start peer: data loss protection required". |
In this commit, we modify our default local feature bits to require the
Data Loss Protection (DLP) feature to be active. Once full Static
Channel Backups are implemented, if we connect to a peer that doesn't
follow the DLP protocol, then the SCBs are useless, as we may not be
able to recover funds. As a result, in prep for full SCB deployment,
we'll now ensure that any peer we connect to, knows of the DLP bit. This
could be a bit more relaxed and allow connections to non-DLP peers,
but reject channel requests to/from them. However, this implementation is
much simpler.