Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify a tag, branch or commit during docker prod build #2520

Conversation

yancyribbens
Copy link
Contributor

@yancyribbens yancyribbens commented Jan 21, 2019

Add build-arg to docker for choosing which branch, tag or commit to run during build time.

@Roasbeef Roasbeef added enhancement docker P3 labels Jan 21, 2019
@halseth halseth added the needs review label Jan 28, 2019
@yancyribbens yancyribbens reopened this Feb 21, 2019
@halseth halseth requested a review from guggero Nov 7, 2019
@guggero guggero self-assigned this Nov 7, 2019
Copy link
Collaborator

@guggero guggero left a comment

The code change is definitely useful and we should have reviewed this a long time ago.

The examples might be a bit confusing as they are, I added some suggestions on how to improve them.

docs/DOCKER.md Outdated Show resolved Hide resolved
docs/DOCKER.md Outdated Show resolved Hide resolved
docs/DOCKER.md Outdated Show resolved Hide resolved
@yancyribbens yancyribbens force-pushed the choose-git-state-during-docker-prod-build branch from 67c7726 to bef8067 Compare Nov 9, 2019
Dockerfile Outdated Show resolved Hide resolved
@guggero guggero requested a review from carlaKC Nov 9, 2019
@yancyribbens yancyribbens force-pushed the choose-git-state-during-docker-prod-build branch from bef8067 to 8d31d36 Compare Nov 9, 2019
Copy link
Collaborator

@guggero guggero left a comment

LGTM 👍

Copy link
Collaborator

@carlaKC carlaKC left a comment

Awesome change 😻 I'm going to get some good use out of this one.
Looks good to me, and works locally.

Tiny nit on the commit name, I think it makes sense to prefix it with dockerfile: since that's where the change is (and the docs change is related to the docker file)

@yancyribbens yancyribbens force-pushed the choose-git-state-during-docker-prod-build branch from 8d31d36 to 3173680 Compare Nov 19, 2019
@yancyribbens
Copy link
Contributor Author

@yancyribbens yancyribbens commented Nov 19, 2019

@carlaKC I see lots of example commits with docker. maybe that would be preferred over dockerfile?

@guggero
Copy link
Collaborator

@guggero guggero commented Nov 19, 2019

Yes, docker: is fine too, thanks!

@guggero guggero added this to WIP in v0.9.0-beta via automation Nov 19, 2019
@guggero guggero moved this from WIP to Approved in v0.9.0-beta Nov 19, 2019
@guggero guggero added this to the 0.9.0 milestone Nov 19, 2019
@guggero guggero added the v0.9.0 label Nov 19, 2019
@halseth halseth merged commit 79051ac into lightningnetwork:master Nov 19, 2019
1 of 2 checks passed
v0.9.0-beta automation moved this from Approved to Done Nov 19, 2019
@carlaKC
Copy link
Collaborator

@carlaKC carlaKC commented Nov 21, 2019

@carlaKC I see lots of example commits with docker. maybe that would be preferred over dockerfile?

Sorry I missed this, too many git emails 🙈 Thanks for the PR!
docker is good as Oli says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker enhancement needs review P3 v0.9.0
Projects
No open projects
v0.9.0-beta
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants