lightningnetwork / lnd Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify a tag, branch or commit during docker prod build #2520
specify a tag, branch or commit during docker prod build #2520
Conversation
The code change is definitely useful and we should have reviewed this a long time ago.
The examples might be a bit confusing as they are, I added some suggestions on how to improve them.
67c7726
to
bef8067
Compare
bef8067
to
8d31d36
Compare
Awesome change
Looks good to me, and works locally.
Tiny nit on the commit name, I think it makes sense to prefix it with dockerfile:
since that's where the change is (and the docs change is related to the docker file)
8d31d36
to
3173680
Compare
@carlaKC I see lots of example commits with |
Yes, |
Sorry I missed this, too many git emails |
Add
build-arg
to docker for choosing which branch, tag or commit to run during build time.