Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: increase default trickle delay from 30s to 1m30s #2538

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
3 participants
@Roasbeef
Copy link
Member

Roasbeef commented Jan 25, 2019

In this commit, we increase the default trickle delay from 30s to 1m30s.
We do this as before we implement the new INV gossip mechanism, we want
to de-emphasise the quick propagation of updates through the network
which eats up bandwidth.

config: increase default trickle delay from 30s to 1m30s
In this commit, we increase the default trickle delay from 30s to 1m30s.
We do this as before we implement the new INV gossip mechanism, we want
to de-emphasise the quick propagation of updates through the network
which eats up bandwidth.

@Roasbeef Roasbeef added this to the 0.5.2 milestone Jan 25, 2019

@@ -49,7 +49,7 @@ const (
defaultRPCHost = "localhost"
defaultMaxPendingChannels = 1
defaultNoSeedBackup = false
defaultTrickleDelay = 30 * 1000
defaultTrickleDelay = 90 * 1000

This comment has been minimized.

Copy link
@cfromknecht

cfromknecht Jan 26, 2019

Collaborator

90 * time.Second?

This comment has been minimized.

Copy link
@halseth

halseth Jan 26, 2019

Collaborator

that would break old configs I guess, but I agree it would be nice to make all flags use time.Duration.

This comment has been minimized.

Copy link
@cfromknecht

cfromknecht Jan 29, 2019

Collaborator

hmm, yeah that is unfortunate that it doesn't. we could migrate to a trickleinterval that uses time.Duration and deprecate trickledelay, though that can be done later

@cfromknecht
Copy link
Collaborator

cfromknecht left a comment

LGTM 🤙

@Roasbeef Roasbeef modified the milestones: 0.5.2, 0.6 Jan 29, 2019

@Roasbeef Roasbeef merged commit e51c58e into lightningnetwork:master Jan 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 56.435%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.