Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: add outgoing channel restriction #2572

Merged

Conversation

joostjager
Copy link
Collaborator

@joostjager joostjager commented Feb 1, 2019

This PR adds the ability to SendPayment to restrict the payment to a specific outgoing channel.

One of the use cases of this is to be able to balance channels passively. Paying a higher fee for a payment, but at the same time increasing the receive capacity of a specific channel.

This is an alternative to making a dedicated payment to yourself to achieve the same goal, which may overall be more costly in terms of routing fees.

@joostjager joostjager force-pushed the outgoing-chan-selection branch 2 times, most recently from c134915 to 4241820 Compare February 1, 2019 14:37
@joostjager joostjager changed the title routing: add outgoing channel restriction [no review] routing: add outgoing channel restriction Feb 1, 2019
@Roasbeef Roasbeef added this to the 0.6 milestone Feb 5, 2019
@joostjager joostjager force-pushed the outgoing-chan-selection branch 3 times, most recently from 56313f6 to c35513d Compare February 6, 2019 07:05
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour rpc Related to the RPC interface routing payments Related to invoices/payments labels Feb 7, 2019
cmd/lncli/commands.go Outdated Show resolved Hide resolved
lnrpc/rpc.proto Outdated Show resolved Hide resolved
routing/pathfind_test.go Show resolved Hide resolved
@joostjager
Copy link
Collaborator Author

@cfromknecht ptal

Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 very useful feature :)

cmd/lncli/commands.go Outdated Show resolved Hide resolved
cmd/lncli/commands.go Show resolved Hide resolved
routing/pathfind_test.go Outdated Show resolved Hide resolved
@joostjager
Copy link
Collaborator Author

@wpaulino ptal

Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour payments Related to invoices/payments routing rpc Related to the RPC interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants