Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: add outgoing channel restriction #2572

Merged

Conversation

@joostjager
Copy link
Collaborator

@joostjager joostjager commented Feb 1, 2019

This PR adds the ability to SendPayment to restrict the payment to a specific outgoing channel.

One of the use cases of this is to be able to balance channels passively. Paying a higher fee for a payment, but at the same time increasing the receive capacity of a specific channel.

This is an alternative to making a dedicated payment to yourself to achieve the same goal, which may overall be more costly in terms of routing fees.

@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch 2 times, most recently from c134915 to 4241820 Feb 1, 2019
@joostjager joostjager changed the title routing: add outgoing channel restriction [no review] routing: add outgoing channel restriction Feb 1, 2019
@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch from 4241820 to 401a12f Feb 4, 2019
@Roasbeef Roasbeef added this to the 0.6 milestone Feb 5, 2019
@joostjager joostjager requested a review from halseth Feb 5, 2019
@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch 3 times, most recently from 56313f6 to c35513d Feb 5, 2019
@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch from c35513d to d69d70a Feb 7, 2019
@joostjager joostjager requested a review from cfromknecht Feb 7, 2019
cmd/lncli/commands.go Outdated Show resolved Hide resolved
lnrpc/rpc.proto Outdated Show resolved Hide resolved
routing/pathfind_test.go Show resolved Hide resolved
@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch from d69d70a to 2898389 Feb 8, 2019
@joostjager
Copy link
Collaborator Author

@joostjager joostjager commented Feb 8, 2019

Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM! 💯 very useful feature :)

cmd/lncli/commands.go Outdated Show resolved Hide resolved
cmd/lncli/commands.go Show resolved Hide resolved
routing/pathfind_test.go Outdated Show resolved Hide resolved
@joostjager joostjager force-pushed the joostjager:outgoing-chan-selection branch from 2898389 to 7c30a8c Feb 8, 2019
@joostjager
Copy link
Collaborator Author

@joostjager joostjager commented Feb 8, 2019

@wpaulino ptal

Copy link
Collaborator

@wpaulino wpaulino left a comment

LGTM 💾

@joostjager joostjager merged commit c44d404 into lightningnetwork:master Feb 9, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 59.737%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants