Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer: deprioritize gossip traffic #2690

Merged

Conversation

cfromknecht
Copy link
Contributor

Should fix #2686

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour p2p Code related to the peer-to-peer behaviour discovery Peer and route discovery / whisper protocol related issues/PRs server labels Feb 23, 2019
@Roasbeef Roasbeef added this to the 0.6 milestone Feb 23, 2019
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other case within the gossiper where we send messages to peers is in the reliable sender, but I think those can remain as is as there shouldn't be that many per peer.

lnpeer/peer.go Show resolved Hide resolved
peer.go Show resolved Hide resolved
server.go Show resolved Hide resolved
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕸

@cfromknecht
Copy link
Contributor Author

The only other case within the gossiper where we send messages to peers is in the reliable sender, but I think those can remain as is as there shouldn't be that many per peer.

Indeed, i think we want these to be prioritized also so that we can remove them from the message store as quickly as possible

@Roasbeef
Copy link
Member

Roasbeef commented Mar 6, 2019

Agreed that we'd want the direct chan ann/sig/update messages to be sent in prio mode.

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💥

Did a connect+openchannel test right after a restart on one of my testnet nodes and also a connect+openchannel with a fresh channel graph. Not a precise measures, but both tests were noticeably snappier (returned from the command line sooner) with this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs enhancement Improvements to existing features / behaviour p2p Code related to the peer-to-peer behaviour server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lnd outgoing gossip flood can cause message timeouts?
3 participants