Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer: deprioritize gossip traffic #2690

Merged

Conversation

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Feb 23, 2019

Should fix #2686

Copy link
Collaborator

@wpaulino wpaulino left a comment

The only other case within the gossiper where we send messages to peers is in the reliable sender, but I think those can remain as is as there shouldn't be that many per peer.

lnpeer/peer.go Show resolved Hide resolved
peer.go Show resolved Hide resolved
server.go Show resolved Hide resolved
@cfromknecht cfromknecht force-pushed the cfromknecht:hwsc-fndg-priority-queue branch from 8e1aac4 to 935ea7d Mar 6, 2019
Copy link
Collaborator

@wpaulino wpaulino left a comment

LGTM 🕸

@cfromknecht
Copy link
Collaborator Author

@cfromknecht cfromknecht commented Mar 6, 2019

The only other case within the gossiper where we send messages to peers is in the reliable sender, but I think those can remain as is as there shouldn't be that many per peer.

Indeed, i think we want these to be prioritized also so that we can remove them from the message store as quickly as possible

@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Mar 6, 2019

Agreed that we'd want the direct chan ann/sig/update messages to be sent in prio mode.

Copy link
Member

@Roasbeef Roasbeef left a comment

LGTM 💥

Did a connect+openchannel test right after a restart on one of my testnet nodes and also a connect+openchannel with a fresh channel graph. Not a precise measures, but both tests were noticeably snappier (returned from the command line sooner) with this patch.

@Roasbeef Roasbeef merged commit c853555 into lightningnetwork:master Mar 6, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 60.216%
Details
@cfromknecht cfromknecht deleted the cfromknecht:hwsc-fndg-priority-queue branch Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants