config: allow adding multiple tls ips and domains#2704
Merged
halseth merged 1 commit intolightningnetwork:masterfrom May 22, 2019
Merged
config: allow adding multiple tls ips and domains#2704halseth merged 1 commit intolightningnetwork:masterfrom
halseth merged 1 commit intolightningnetwork:masterfrom
Conversation
Roasbeef
added
enhancement
MDrollette
force-pushed
the
multiple-opts
branch
from
58591d9 to
20566f5
Compare
MDrollette
force-pushed
the
multiple-opts
branch
from
20566f5 to
261558a
Compare
Contributor
Author
|
This change would still be relevant, I think, since that PR doesn't remove these flags. It just allows for alternatively using Let's Encrypt certs. |
cfromknecht
approved these changes
May 22, 2019
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
@MDrollette thanks for adding this, very nice fix! LGTM 🚀
matheusd
pushed a commit
to matheusd/dcrlnd
that referenced
this pull request
Feb 25, 2020
Minor addition to lightningnetwork#2704, because I was wondering how to set multiple tlsextra entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting multiple
--tlsextraipand--tlsextradomainto be used when generating tls certs.fixes #1492