Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow adding multiple tls ips and domains #2704

Merged
merged 1 commit into from
May 22, 2019

Conversation

MDrollette
Copy link
Contributor

Allows setting multiple --tlsextraip and --tlsextradomain to be used when generating tls certs.

fixes #1492

@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour rpc Related to the RPC interface gRPC config Parameters/arguments/config file related issues/PRs P3 might get fixed, nice to have labels Mar 1, 2019
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 👍

Might not be needed any more if #2428 is merged and any certificate can be used. But still, a nice feature that would have been useful to me in the past.

@MDrollette
Copy link
Contributor Author

This change would still be relevant, I think, since that PR doesn't remove these flags. It just allows for alternatively using Let's Encrypt certs.

Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MDrollette thanks for adding this, very nice fix! LGTM 🚀

@cfromknecht cfromknecht requested a review from wpaulino May 22, 2019 05:30
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@halseth halseth merged commit 4806003 into lightningnetwork:master May 22, 2019
matheusd pushed a commit to matheusd/dcrlnd that referenced this pull request Feb 25, 2020
Minor addition to lightningnetwork#2704, because I was wondering how to set multiple tlsextra entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Parameters/arguments/config file related issues/PRs enhancement Improvements to existing features / behaviour gRPC P3 might get fixed, nice to have rpc Related to the RPC interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple domains being added to SAN via tlsextradomain(s)
5 participants