Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow adding multiple tls ips and domains #2704

Merged
merged 1 commit into from May 22, 2019

Conversation

@MDrollette
Copy link
Contributor

@MDrollette MDrollette commented Feb 26, 2019

Allows setting multiple --tlsextraip and --tlsextradomain to be used when generating tls certs.

fixes #1492

@cfromknecht cfromknecht added this to the 0.7 milestone Apr 11, 2019
Copy link
Collaborator

@guggero guggero left a comment

tACK 👍

Might not be needed any more if #2428 is merged and any certificate can be used. But still, a nice feature that would have been useful to me in the past.

Loading

@MDrollette
Copy link
Contributor Author

@MDrollette MDrollette commented Apr 19, 2019

This change would still be relevant, I think, since that PR doesn't remove these flags. It just allows for alternatively using Let's Encrypt certs.

Loading

Copy link
Collaborator

@cfromknecht cfromknecht left a comment

@MDrollette thanks for adding this, very nice fix! LGTM 🚀

Loading

@cfromknecht cfromknecht requested a review from wpaulino May 22, 2019
Copy link
Collaborator

@halseth halseth left a comment

LGTM 🔥

Loading

@halseth halseth merged commit 4806003 into lightningnetwork:master May 22, 2019
2 checks passed
Loading
matheusd added a commit to matheusd/dcrlnd that referenced this issue Jan 9, 2020
Minor addition to lightningnetwork#2704, because I was wondering how to set multiple tlsextra entries.
matheusd added a commit to matheusd/dcrlnd that referenced this issue Jan 22, 2020
Minor addition to lightningnetwork#2704, because I was wondering how to set multiple tlsextra entries.
matheusd added a commit to matheusd/dcrlnd that referenced this issue Feb 25, 2020
Minor addition to lightningnetwork#2704, because I was wondering how to set multiple tlsextra entries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants