Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow adding multiple tls ips and domains #2704

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
5 participants
@MDrollette
Copy link
Contributor

commented Feb 26, 2019

Allows setting multiple --tlsextraip and --tlsextradomain to be used when generating tls certs.

fixes #1492

@MDrollette MDrollette force-pushed the MDrollette:multiple-opts branch from 58591d9 to 20566f5 Mar 5, 2019

@MDrollette MDrollette force-pushed the MDrollette:multiple-opts branch from 20566f5 to 261558a Mar 10, 2019

@cfromknecht cfromknecht added this to the 0.7 milestone Apr 11, 2019

@guggero
Copy link
Contributor

left a comment

tACK 👍

Might not be needed any more if #2428 is merged and any certificate can be used. But still, a nice feature that would have been useful to me in the past.

@MDrollette

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

This change would still be relevant, I think, since that PR doesn't remove these flags. It just allows for alternatively using Let's Encrypt certs.

@cfromknecht
Copy link
Collaborator

left a comment

@MDrollette thanks for adding this, very nice fix! LGTM 🚀

@cfromknecht cfromknecht requested a review from wpaulino May 22, 2019

@halseth
Copy link
Collaborator

left a comment

LGTM 🔥

@halseth halseth merged commit 4806003 into lightningnetwork:master May 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 60.322%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.