Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnrpc+rpcserver: display payreq via listpayments #2717

Merged
merged 4 commits into from Jun 1, 2019

Conversation

Projects
None yet
4 participants
@cfromknecht
Copy link
Collaborator

commented Feb 28, 2019

blocked by #2761

@wpaulino
Copy link
Collaborator

left a comment

LGTM 💊

@halseth

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

Conflicts with #2761.

Maybe we should write the payment in an "unsettled" state to the DB, such that the payment request (and other information) is persisted across restarts? Currently only what is persisted by the router will be remembered.

@cfromknecht

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2019

@halseth do you want to merge this #2761? first and last commit could probably be cherry-picked, you'd probably know best about where to store it

@halseth

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

I'll make sure #2761 adds the payreq field such that this can easily be rebased on top :)

@Roasbeef

This comment has been minimized.

Copy link
Member

commented May 10, 2019

Needs a rebase!

@halseth halseth referenced this pull request May 22, 2019

Merged

[reliable payments] router payment state machine #2761

3 of 3 tasks complete

@cfromknecht cfromknecht removed the blocked label May 28, 2019

@cfromknecht cfromknecht force-pushed the cfromknecht:send-payment-payreq branch from 89de16d to 406f99c May 28, 2019

@cfromknecht

This comment has been minimized.

Copy link
Collaborator Author

commented May 29, 2019

Show resolved Hide resolved lnd_test.go Outdated

cfromknecht added some commits May 29, 2019

@cfromknecht cfromknecht force-pushed the cfromknecht:send-payment-payreq branch from 406f99c to 3f08041 May 29, 2019

Show resolved Hide resolved rpcserver.go
Show resolved Hide resolved lntest/itest/lnd_test.go

@cfromknecht cfromknecht force-pushed the cfromknecht:send-payment-payreq branch from 3f08041 to a826d85 May 30, 2019

@cfromknecht

This comment has been minimized.

Copy link
Collaborator Author

commented May 30, 2019

@halseth ptal

@Roasbeef
Copy link
Member

left a comment

LGTM 🌋

@Roasbeef Roasbeef merged commit 4068e78 into lightningnetwork:master Jun 1, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 60.767%
Details

@cfromknecht cfromknecht deleted the cfromknecht:send-payment-payreq branch Jun 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.