Skip to content

lnrpc+rpcserver: display payreq via listpayments#2717

Merged
Roasbeef merged 4 commits into
lightningnetwork:masterfrom
cfromknecht:send-payment-payreq
Jun 1, 2019
Merged

lnrpc+rpcserver: display payreq via listpayments#2717
Roasbeef merged 4 commits into
lightningnetwork:masterfrom
cfromknecht:send-payment-payreq

Conversation

@cfromknecht
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht commented Feb 28, 2019 •
edited
Loading

blocked by #2761

@cfromknecht cfromknecht mentioned this pull request Feb 28, 2019
Closed
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour rpc Related to the RPC interface gRPC payments Related to invoices/payments labels Mar 1, 2019
@cfromknecht cfromknecht force-pushed the send-payment-payreq branch from a502e35 to 89de16d Compare March 13, 2019 20:37
wpaulino
wpaulino approved these changes Mar 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💊

@halseth
Copy link
Copy Markdown
Contributor

halseth commented Mar 19, 2019 •
edited
Loading

Conflicts with #2761.

Maybe we should write the payment in an "unsettled" state to the DB, such that the payment request (and other information) is persisted across restarts? Currently only what is persisted by the router will be remembered.

@cfromknecht
Copy link
Copy Markdown
Contributor Author

cfromknecht commented Mar 22, 2019

@halseth do you want to merge this #2761? first and last commit could probably be cherry-picked, you'd probably know best about where to store it

@halseth
Copy link
Copy Markdown
Contributor

halseth commented Apr 1, 2019

I'll make sure #2761 adds the payreq field such that this can easily be rebased on top :)

@cfromknecht cfromknecht added this to the 0.7 milestone Apr 11, 2019
@misovan misovan mentioned this pull request Apr 18, 2019
Closed
@Roasbeef
Copy link
Copy Markdown
Member

Roasbeef commented May 10, 2019

Needs a rebase!

@halseth halseth mentioned this pull request May 22, 2019
Merged
3 tasks
@cfromknecht cfromknecht force-pushed the send-payment-payreq branch from 89de16d to 406f99c Compare May 28, 2019 23:56
@cfromknecht
Copy link
Copy Markdown
Contributor Author

cfromknecht commented May 29, 2019

@Roasbeef @halseth PTAL

wpaulino
wpaulino approved these changes May 29, 2019
View reviewed changes
Comment thread lnd_test.go Outdated
@cfromknecht cfromknecht force-pushed the send-payment-payreq branch from 406f99c to 3f08041 Compare May 29, 2019 23:31
halseth
halseth reviewed May 30, 2019
View reviewed changes
Comment thread rpcserver.go
Comment thread lntest/itest/lnd_test.go Outdated
@cfromknecht cfromknecht force-pushed the send-payment-payreq branch from 3f08041 to a826d85 Compare May 30, 2019 21:18
@cfromknecht
Copy link
Copy Markdown
Contributor Author

cfromknecht commented May 30, 2019

@halseth ptal

Roasbeef
Roasbeef approved these changes Jun 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌋

@Roasbeef Roasbeef merged commit 4068e78 into lightningnetwork:master Jun 1, 2019
@cfromknecht cfromknecht deleted the send-payment-payreq branch June 1, 2019 00:13
@ottosuess ottosuess mentioned this pull request Jun 12, 2019
Closed
@wpaulino wpaulino mentioned this pull request Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

+2 more reviewers

@halseth halseth halseth left review comments

@wpaulino wpaulino wpaulino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvements to existing features / behaviour gRPC payments Related to invoices/payments rpc Related to the RPC interface

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

4 participants

@cfromknecht @halseth @Roasbeef @wpaulino