Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: retrieve Channel ChanId from OpenChannel record #2824

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@wpaulino
Copy link
Collaborator

@wpaulino wpaulino commented Mar 22, 2019

This is a better alternative than retrieving it from the graph as it's
possible that the channel is pruned from it doing to not having any
updates within the past two weeks.

Fixes #2823.

This is a better alternative than retrieving it from the graph as it's
possible that the channel is pruned from it doing to not having any
updates within the past two weeks.
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

Good simplification, should also make the rpc snappier. LGTB

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Mar 22, 2019

@wpaulino race test needs a restart

Copy link
Collaborator

@halseth halseth left a comment

LGTM 💯

@halseth halseth merged commit ec70965 into lightningnetwork:master Mar 27, 2019
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.03%) to 59.757%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wpaulino wpaulino deleted the wpaulino:chanid-openchannel branch Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants