Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcserver: retrieve Channel ChanId from OpenChannel record #2824

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

wpaulino
Copy link
Contributor

This is a better alternative than retrieving it from the graph as it's
possible that the channel is pruned from it doing to not having any
updates within the past two weeks.

Fixes #2823.

This is a better alternative than retrieving it from the graph as it's
possible that the channel is pruned from it doing to not having any
updates within the past two weeks.
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good simplification, should also make the rpc snappier. LGTB ♟

@cfromknecht
Copy link
Contributor

@wpaulino race test needs a restart

Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@halseth halseth merged commit ec70965 into lightningnetwork:master Mar 27, 2019
@wpaulino wpaulino deleted the chanid-openchannel branch March 27, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants