Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal: catch all termination signals by default #2842

Merged
merged 1 commit into from Mar 27, 2019

Conversation

@Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented Mar 27, 2019

In this commit, we modify the primary signal package to instead catch
all signals. Before this commit, it would only catch the interrupt
signal sent from the kernel. With this new commit, we'll now also catch
(or attempt to catch): SIGABRT, SIGTERM, SIGSTOP, and SIGQUIT.

@Roasbeef
Copy link
Member Author

@Roasbeef Roasbeef commented Mar 27, 2019

Before this PR, we didn't attempt to catch SIGTERM which is customarily used by systemd to shutdown active services. Many of the raspberry pi guides circulating out there use a ssytemd set up to handle creation/destruction of the lnd process.

Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTB 💰

signal/signal.go Outdated Show resolved Hide resolved
In this commit, we modify the primary `signal` package to instead catch
all signals. Before this commit, it would only catch the interrupt
signal sent from the kernel. With this new commit, we'll now also catch
(or attempt to catch): `SIGABRT`, `SIGTERM`, `SIGSTOP`, and `SIGQUIT`.
@Roasbeef Roasbeef force-pushed the Roasbeef:catch-all-signals branch from 4a83170 to c731a99 Mar 27, 2019
@Roasbeef Roasbeef merged commit 55ddca6 into lightningnetwork:master Mar 27, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@vamp111
Copy link

@vamp111 vamp111 commented Apr 3, 2019

expected update reliese anytime soon ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants