Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channeldb/graph: filter zombie channels in FilterKnownChanIDs #2893

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

cfromknecht
Copy link
Contributor

@cfromknecht cfromknecht commented Apr 5, 2019

This commit modifies FilterKnownChanIDs to skip edges that
we ourselves have deemed zombies. This prevents us from requesting
the updates from the remote peer, as this wastes bandwidth and cpu
cycles.

With the addition of regular historical spot checks in #2740, this will
prevent upgraded LND nodes from rerequesting these channels from
unupgraded LND nodes or implementations that don't filter out
zombies. There are currently 3.3k zombie channels, so this would save
at least 3MB on historical syncs with such peers.

@cfromknecht cfromknecht force-pushed the no-want-zombie branch 2 times, most recently from 66189b6 to c4bead7 Compare April 5, 2019 06:52
Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

channeldb/graph.go Outdated Show resolved Hide resolved
channeldb/graph.go Outdated Show resolved Hide resolved
This commit modifies FilterKnownChanIDs to skip edges that
we ourselves have deemed zombies. This prevents us from requesting
the updates from them, as this wastes bandwidth and cpu cycles.
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛩

Observed the unnecessary queries on one of my nodes as it would re-request these same zombies every 30 minutes or so.

@cfromknecht cfromknecht merged commit a52f013 into lightningnetwork:master Apr 5, 2019
@cfromknecht cfromknecht deleted the no-want-zombie branch April 11, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants