Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channeldb/graph: filter zombie channels in FilterKnownChanIDs #2893

Merged
merged 1 commit into from Apr 5, 2019

Conversation

@cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Apr 5, 2019

This commit modifies FilterKnownChanIDs to skip edges that
we ourselves have deemed zombies. This prevents us from requesting
the updates from the remote peer, as this wastes bandwidth and cpu
cycles.

With the addition of regular historical spot checks in #2740, this will
prevent upgraded LND nodes from rerequesting these channels from
unupgraded LND nodes or implementations that don't filter out
zombies. There are currently 3.3k zombie channels, so this would save
at least 3MB on historical syncs with such peers.

@cfromknecht cfromknecht force-pushed the cfromknecht:no-want-zombie branch 2 times, most recently from 66189b6 to c4bead7 Apr 5, 2019
@halseth
halseth approved these changes Apr 5, 2019
Copy link
Collaborator

@halseth halseth left a comment

LGTM 👍

channeldb/graph.go Outdated Show resolved Hide resolved
@cfromknecht cfromknecht force-pushed the cfromknecht:no-want-zombie branch from c4bead7 to 678114f Apr 5, 2019
channeldb/graph.go Outdated Show resolved Hide resolved
This commit modifies FilterKnownChanIDs to skip edges that
we ourselves have deemed zombies. This prevents us from requesting
the updates from them, as this wastes bandwidth and cpu cycles.
@cfromknecht cfromknecht force-pushed the cfromknecht:no-want-zombie branch from 678114f to e91bacd Apr 5, 2019
Copy link
Member

@Roasbeef Roasbeef left a comment

LGTM

Observed the unnecessary queries on one of my nodes as it would re-request these same zombies every 30 minutes or so.

@cfromknecht cfromknecht merged commit a52f013 into lightningnetwork:master Apr 5, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on no-want-zombie at 59.661%
Details
@cfromknecht cfromknecht deleted the cfromknecht:no-want-zombie branch Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants