Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build LND subservers when building docker image #2974

Merged
merged 2 commits into from May 20, 2019

Conversation

Projects
None yet
4 participants
@OpinionatedGeek
Copy link
Contributor

commented Apr 18, 2019

Now that the official releases are built with subservers, can/should we build docker images with subservers by default too?

This one-line change is all I needed to do to build LND with subservers so loop would work with the docker image.

(Checklist not applicable - it's a one-line change to a docker file rather than a go file.)

Build LND subservers when building docker image
Now that the official releases are built with subservers, can/should we build docker images with subservers by default too?

This one-line change is all I needed to do to build LND with subservers so loop would work with the docker image.
@wpaulino

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

Now that the official releases are built with subservers, can/should we build docker images with subservers by default too?

Doing so makes sense to me. Could you also update lnd/Dockerfile?

Root Dockerfile now builds subservers
Root Dockerfile now builds subservers required for Loop functionality.
@OpinionatedGeek

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

lnd/Dockerfile updated as requested. (Apologies - I didn't even know it was there.)

@cfromknecht
Copy link
Collaborator

left a comment

LGTM 💯

@halseth
Copy link
Collaborator

left a comment

LGTM 🐳

@halseth halseth merged commit 60bad9a into lightningnetwork:master May 20, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.4%) to 60.225%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.