Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jackpal/gateway to v1.0.5 #2989

Merged
merged 1 commit into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@meeDamian
Copy link
Contributor

commented Apr 22, 2019

This is a Linux-specific fix to an issue, where running lnd with nat=true causes instant crash on some distributions of linux.

Currently used version of this library depends on ip and route being located in /usr/bin/. Not surprisingly, many distributions (ex. Alpine) don't have them there. v1.0.5 fixes it by relying on $PATH instead: jackpal/gateway@5795ac8.

Pull Request Checklist

  • If this is your first time contributing, we recommend you read the Code
    Contribution Guidelines
  • All changes are Go version 1.12 compliant
  • No new code
  • Running make check does not fail any tests
  • Running go vet does not report any issues
  • Running make lint does not report any new issues that did not
    already exist
  • All commits build properly and pass tests. Only in exceptional
    cases it can be justifiable to violate this condition. In that case, the
    reason should be stated in the commit message.
  • Commits have a logical structure according to Ideal Git Commit Structure

@meeDamian meeDamian referenced this pull request Apr 22, 2019

Closed

Fix nat #6

@cfromknecht
Copy link
Collaborator

left a comment

LGTM 🦐

@cfromknecht cfromknecht added this to the 0.6.1 milestone Apr 23, 2019

@cfromknecht cfromknecht merged commit 1c22474 into lightningnetwork:master Apr 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 59.914%
Details

@meeDamian meeDamian deleted the meeDamian:gateway-v1.0.5 branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.