Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tor: use string comparison to check min supported version #3038

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@wpaulino
Copy link
Collaborator

commented May 3, 2019

The current method would not allow version strings like 0.4.0.5 since it would check every number of the version string individually.

tor: use string comparison to check min supported version
The current method would not allow version strings like 0.4.0.5 since it
would check every number of the version string individually.

@Roasbeef Roasbeef added this to the 0.6.1 milestone May 3, 2019

@Roasbeef
Copy link
Member

left a comment

LGTM 🏆

@Roasbeef Roasbeef merged commit 44eb232 into lightningnetwork:master May 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 60.161%
Details

@wpaulino wpaulino deleted the wpaulino:tor-version-check branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.