Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reliable payments] add routing.Route (de)serialization + test #3064

Merged
merged 1 commit into from May 9, 2019

Conversation

Projects
None yet
3 participants
@halseth
Copy link
Collaborator

commented May 9, 2019

We will store the routes used during payment attempts, so we need
serialization code.

Split off from #2761

channeldb: add Route (de)serialization + test
We will store the routes used during payment attempts, so we need
serialization code.

@halseth halseth referenced this pull request May 9, 2019

Merged

[reliable payments] router payment state machine #2761

3 of 3 tasks complete
@Roasbeef
Copy link
Member

left a comment

LGTM

@Roasbeef Roasbeef merged commit fb1819b into lightningnetwork:master May 9, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 60.206%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

func serializeRoute(w io.Writer, r route.Route) error {
if err := WriteElements(w,
r.TotalTimeLock, r.TotalFees, r.TotalAmount, r.SourcePubKey[:],

This comment has been minimized.

Copy link
@joostjager

joostjager May 14, 2019

Collaborator

TotalFees is redundant info and can be derived by TotalAmount-r.Hops[len(r.Hops)-1].AmtToForward

This comment has been minimized.

Copy link
@halseth

halseth May 15, 2019

Author Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.