Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisessweep+rpc+cmd/lncli: expose pending input sweeps over RPC + CLI #3089
Conversation
wpaulino
requested a review
from joostjager
May 17, 2019
wpaulino
added
utxo sweeping
cli
enhancement
fees
rpc
labels
May 17, 2019
joostjager
reviewed
May 17, 2019
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
dd7a59c
to
394bd91
May 17, 2019
This comment has been minimized.
This comment has been minimized.
|
PTAL @joostjager. |
wpaulino
added this to the 0.7 milestone
May 17, 2019
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
394bd91
to
6ec7bb9
May 18, 2019
wpaulino
requested a review
from Roasbeef
May 18, 2019
joostjager
reviewed
May 20, 2019
lnrpc/invoicesrpc/invoices.pb.go Outdated
lnrpc/rpc.proto Outdated
rpcserver.go Outdated
sweep/sweeper.go Outdated
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
6ec7bb9
to
9118e3c
May 22, 2019
joostjager
reviewed
May 22, 2019
sweep/sweeper.go Outdated
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
9118e3c
to
9fd0c47
May 23, 2019
| sweep transaction of the output. | ||
| */ | ||
| uint32 next_broadcast_height = 6 [json_name = "next_broadcast_height"]; | ||
| } |
This comment has been minimized.
This comment has been minimized.
Roasbeef
May 25, 2019
Member
Once we circle back and add retargeting, it may be useful to expose what the next fee rate would be.
rpcserver.go Outdated
cmd/lncli/types.go Outdated
cmd/lncli/types.go Outdated
joostjager
reviewed
May 27, 2019
sweep/sweeper.go Outdated
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
9fd0c47
to
22b401b
May 27, 2019
wpaulino
reviewed
May 27, 2019
sweep/sweeper.go Outdated
joostjager
reviewed
May 28, 2019
| for _, pendingInput := range s.pendingInputs { | ||
| // Only the exported fields are set, as we expect the response | ||
| // to only be consumed externally. | ||
| pendingInputs = append(pendingInputs, &PendingInput{ |
This comment has been minimized.
This comment has been minimized.
joostjager
May 28, 2019
Collaborator
I had the same thing with creating a snapshot in mission control and introduced separate exported structs for the snapshot. I think it is cleaner. (non blocking)
This comment has been minimized.
This comment has been minimized.
wpaulino
May 28, 2019
Author
Collaborator
Yeah that was how the initial design of the PR approached it, but I opted for reusing the same struct to result in less code, though the difference is not much.
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
22b401b
to
1c340b9
May 28, 2019
Roasbeef
approved these changes
May 29, 2019
|
Tested locally, works as advertised! LGTM contingent in unifying the byte reversal (in |
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
1c340b9
to
cfcc0b9
May 29, 2019
lnrpc/rpc.swagger.json Outdated
rpcserver.go Outdated
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
cfcc0b9
to
0b6541a
May 29, 2019
wpaulino
referenced this pull request
May 29, 2019
Merged
sweep+rpc: add support to bump fee of inputs/transactions #3140
This comment has been minimized.
This comment has been minimized.
|
@wpaulino needs rebase |
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
0b6541a
to
70b32d5
Jun 1, 2019
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
70b32d5
to
0c525ca
Jun 3, 2019
joostjager
reviewed
Jun 4, 2019
rpcserver.go Outdated
sweep/sweeper.go Outdated
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
0c525ca
to
fcb0467
Jun 4, 2019
This comment has been minimized.
This comment has been minimized.
|
PTAL @Roasbeef @joostjager. |
joostjager
approved these changes
Jun 5, 2019
|
Tested and found that it works. Only minor comment is that the field name |
wpaulino
added some commits
May 27, 2019
wpaulino
force-pushed the
wpaulino:pendingsweeps-rpc
branch
from
fcb0467
to
26230cd
Jun 5, 2019
This comment has been minimized.
This comment has been minimized.
Agreed. This is why Rebased to address a |
wpaulino commentedMay 17, 2019
In this PR, we expose the set of pending inputs that the UtxoSweeper is currently attempting to sweep. This will serve as preparatory work for allowing users to perform fee bumps. Due to the UtxoSweeper's asynchronous nature, we are not able to quickly report on whether a fee bump succeeded or not, so we resort towards exposing its internal fee rate bucketing system over RPC to give users an indication of what's currently being swept and with what fee rate.
I opted to only expose the sweeping fee rate for each bucket, along with all of the inputs within each bucket and their individual fee rates for now. Looking for feedback on whether we could be exposing this information better.
Depends on #3026.