Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fundingmanager: bump max non-initiator funding timeout to 2 weeks #3098

Merged

Conversation

Projects
None yet
3 participants
@cfromknecht
Copy link
Collaborator

commented May 18, 2019

The previous value was set to two days, which may not be enough to
handle large fee spikes where users still which to submit channels with
a low fee and don't mind lowering their time preference. Since the
timeout is only applied to channels that we don't initiate, there's real
downside since it's not our funds that are locked up.

fundingmanager: bump max non-initiator funding timeout to 2 weeks
The previous value was set to two days, which may not be enough to
handle large fee spikes where users still which to submit channels with
a low fee and don't mind lowering their time preference. Since the
timeout is only applied to channels that we don't initiate, there's real
downside since it's not our funds that are locked up.
@Roasbeef
Copy link
Member

left a comment

LGTM 🌈

@cfromknecht cfromknecht requested a review from halseth May 22, 2019

@halseth
Copy link
Collaborator

left a comment

With the latest fee spike, this could come in handy 🤓

@halseth halseth merged commit 437f839 into lightningnetwork:master May 22, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.03%) to 60.299%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cfromknecht cfromknecht deleted the cfromknecht:increase-funding-timeout branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.