fundingmanager: bump max non-initiator funding timeout to 2 weeks#3098
Merged
halseth merged 1 commit intolightningnetwork:masterfrom May 22, 2019
Merged
Conversation
The previous value was set to two days, which may not be enough to handle large fee spikes where users still which to submit channels with a low fee and don't mind lowering their time preference. Since the timeout is only applied to channels that we don't initiate, there's real downside since it's not our funds that are locked up.
halseth
approved these changes
May 22, 2019
Contributor
halseth
left a comment
halseth
left a comment
There was a problem hiding this comment.
With the latest fee spike, this could come in handy 🤓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous value was set to two days, which may not be enough to
handle large fee spikes where users still which to submit channels with
a low fee and don't mind lowering their time preference. Since the
timeout is only applied to channels that we don't initiate, there's real
downside since it's not our funds that are locked up.