Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery/sync_manager: restart historical sync on first connected peer #3103

Merged

Conversation

halseth
Copy link
Contributor

@halseth halseth commented May 21, 2019

To handle the case where we have been without peers, and get a new
connection, we reset the historical scan booleans when the first active
syncer is connected to trigger another historical sync.

This would cause integration tests to be flaky (especially with Neutrino), since we would risk not getting graph updates after having being disconnected.

@halseth halseth added discovery Peer and route discovery / whisper protocol related issues/PRs graph neutrino Lightweight neutrino backend-type test flake itests Issues related to integration tests. labels May 21, 2019
@halseth halseth requested a review from wpaulino May 21, 2019 13:54
@halseth halseth mentioned this pull request May 21, 2019
8 tasks
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An alternative approach would be to modify the historical sync interval in the integration tests, though I think this is still useful given the following scenario: if you've lost all your peers and start receiving new updates at tip, you won't be able to process some of these channels if you've yet to see their channel announcement, so performing a historical sync before doing so would make sense.

LGTM 📦

case !initialHistoricalSyncCompleted:
s.setSyncType(PassiveSync)
m.inactiveSyncers[s.cfg.peerPub] = s

// Otherwise, it should be initialized as active.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: seems like a redundant comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed: 9c9ac36

// TestSyncManagerHistoricalSyncOnReconnect tests that the sync manager will
// re-trigger a historical sync when a new peer connects after a historical
// sync has completed, but we have lost all peers.
func TestSyncManagerHistoricalSyncOnReconnect(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: would prefer if this commit was squashed with what introduced the behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer splitting a bugfix and the test reproducing the bug in separate commits. Especially when I'm reviewing this makes it easy to cherry-pick the test commit on master to exercise the failing scenario.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but that wasn't the case here. The non-test changes alone didn't have an impact on the tests 😛

Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squash! ✅

@halseth halseth force-pushed the syncmanager-resync-historical branch from 538b403 to 9c9ac36 Compare May 24, 2019 09:00
To handle the case where we have been without peers, and get a new
connection, we reset the historical scan booleans when the first active
syncer is connected to trigger another historical sync.
…nect

TestSyncManagerHistoricalSyncOnReconnect tests that the sync manager will
re-trigger a historical sync when a new peer connects after a historical
sync has completed, but we have lost all peers.
@halseth halseth force-pushed the syncmanager-resync-historical branch from 9c9ac36 to 6ba6982 Compare May 24, 2019 09:05
@halseth halseth merged commit af3b04e into lightningnetwork:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Peer and route discovery / whisper protocol related issues/PRs graph itests Issues related to integration tests. neutrino Lightweight neutrino backend-type test flake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants