Skip to content

cmd/lncli: properly parse channel backup within lncli create #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

cmd/lncli: properly parse channel backup within lncli create #3104

merged 1 commit into from
May 23, 2019

Conversation

@wpaulino
Copy link
Contributor

@wpaulino wpaulino commented May 21, 2019

Fixes #3102.

@wpaulino wpaulino mentioned this pull request May 21, 2019
Closed
cfromknecht
cfromknecht approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@cfromknecht cfromknecht added this to the 0.7 milestone May 22, 2019
Roasbeef
Roasbeef approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛽️

@Roasbeef Roasbeef merged commit c654b82 into lightningnetwork:master May 23, 2019
@wpaulino wpaulino deleted the lncli-create-restore-backup branch May 23, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

+1 more reviewer

@cfromknecht cfromknecht cfromknecht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.7

Development

Successfully merging this pull request may close these issues.

cannot recover wallet through channels.backup

3 participants

@wpaulino @Roasbeef @cfromknecht