Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neutrino: enable user to assert filter header chain. #3118

Conversation

Projects
None yet
4 participants
@valentinewallace
Copy link
Collaborator

commented May 25, 2019

In the case that neutrino's filter header chain is inaccurate, the user can pass in a filter header to neutrino that causes it to reset its chain and resync.

@valentinewallace valentinewallace force-pushed the valentinewallace:neutrino-assert-filter-header branch from e1a6a0e to 990c201 May 25, 2019

@valentinewallace valentinewallace requested a review from Roasbeef May 28, 2019

@Roasbeef Roasbeef requested review from wpaulino and removed request for Roasbeef May 28, 2019

Show resolved Hide resolved go.mod Outdated
Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved config.go Outdated
Show resolved Hide resolved chainregistry.go Outdated

@valentinewallace valentinewallace force-pushed the valentinewallace:neutrino-assert-filter-header branch from 990c201 to 499ab74 May 29, 2019

Show resolved Hide resolved chainregistry.go Outdated

@cfromknecht cfromknecht added this to the 0.7 milestone May 29, 2019

Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved chainregistry.go Outdated
Show resolved Hide resolved chainregistry.go Outdated

@valentinewallace valentinewallace force-pushed the valentinewallace:neutrino-assert-filter-header branch 2 times, most recently from cb6a3b1 to e6749b4 May 30, 2019

@cfromknecht
Copy link
Collaborator

left a comment

LGTM

@wpaulino
Copy link
Collaborator

left a comment

LGTM 🥁

@wpaulino
Copy link
Collaborator

left a comment

Blocked by lightninglabs/neutrino#152. Will need another dependency update once that's in master.

@cfromknecht

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

@valentinewallace ready for dep update

@valentinewallace valentinewallace force-pushed the valentinewallace:neutrino-assert-filter-header branch from e6749b4 to d87dc67 Jun 6, 2019

Show resolved Hide resolved config.go Outdated
Show resolved Hide resolved go.mod Outdated

@valentinewallace valentinewallace force-pushed the valentinewallace:neutrino-assert-filter-header branch from d87dc67 to 25b540f Jun 6, 2019

@Roasbeef
Copy link
Member

left a comment

LGTM 🗿

@Roasbeef Roasbeef merged commit 52b7603 into lightningnetwork:master Jun 7, 2019

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 60.881%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.