Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chanbackup: close temp SCB file before rename #3129

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@Roasbeef
Copy link
Member

commented May 27, 2019

It has been reported that on Windows, the current file swap process
doesn't properly work since we still have the file open when we try to
rename it. In order to fix this, we'll now close the file before we
rename it.

chanbackup: close temp SCB file before rename
It has been reported that on Windows, the current file swap process
doesn't properly work since we still have the file open when we try to
rename it. In order to fix this, we'll now close the file _before_ we
rename it.

@Roasbeef Roasbeef added this to the 0.7 milestone May 27, 2019

@cfromknecht
Copy link
Collaborator

left a comment

LGTM 🏖

@wpaulino
Copy link
Collaborator

left a comment

LGTM 🦠

@cfromknecht cfromknecht merged commit cd285d6 into lightningnetwork:master May 28, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on scb-fix-windows at 60.696%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.