chanbackup: close temp SCB file before rename#3129
Merged
cfromknecht merged 1 commit intolightningnetwork:masterfrom May 28, 2019
Merged
chanbackup: close temp SCB file before rename#3129cfromknecht merged 1 commit intolightningnetwork:masterfrom
cfromknecht merged 1 commit intolightningnetwork:masterfrom
Conversation
It has been reported that on Windows, the current file swap process doesn't properly work since we still have the file open when we try to rename it. In order to fix this, we'll now close the file _before_ we rename it.
cfromknecht
added
safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has been reported that on Windows, the current file swap process
doesn't properly work since we still have the file open when we try to
rename it. In order to fix this, we'll now close the file before we
rename it.