Repository navigation
Add gRPC performance Prometheus exporter. - #3134
Merged
Roasbeef merged 2 commits intoJun 12, 2019
Merged
Conversation
Roasbeef
requested changes
May 29, 2019
| @@ -0,0 +1,9 @@ | |||
| package monitoring | |||
|
|
|||
| // PrometheusConfig is the set of configuration data that specifies | |||
Member
There was a problem hiding this comment.
Alternatively, this can live in lncfg and have two versions: one with w/ the build tag, and one w/o it. This way, if the user doesn't have this tag enabled, then it won't show up in lnd -h.
Contributor
Author
There was a problem hiding this comment.
IIUC, fixed.
| case macService != nil: | ||
| unaryInterceptor = macService.UnaryServerInterceptor(permissions) | ||
| streamInterceptor = macService.StreamServerInterceptor(permissions) | ||
| case monitoring.Enabled: |
Member
There was a problem hiding this comment.
Rather than check this manually here independent of the build tag, I think this can be melded in with the current monitoring.Start method.
Contributor
Author
There was a problem hiding this comment.
Hm, server options need to be set before any services can register with the grpc server. Lmk if my solution works.
valentinewallace
force-pushed
the
grpc-perf-interceptor
branch
2 times, most recently
from
May 31, 2019 19:52
0c2ca1b to
9fc1a34
Compare
Roasbeef
requested changes
May 31, 2019
Roasbeef
requested changes
May 31, 2019
Roasbeef
reviewed
May 31, 2019
cfromknecht
reviewed
Jun 1, 2019
valentinewallace
force-pushed
the
grpc-perf-interceptor
branch
3 times, most recently
from
June 6, 2019 08:47
b409d45 to
5e8a404
Compare
Roasbeef
requested changes
Jun 6, 2019
Roasbeef
left a comment
Roasbeef
left a comment
Member
There was a problem hiding this comment.
Diff looking much better now IMO, few more final comments, and then I think this is ready to land
valentinewallace
force-pushed
the
grpc-perf-interceptor
branch
3 times, most recently
from
June 6, 2019 23:11
858a13c to
9b44375
Compare
Roasbeef
reviewed
Jun 7, 2019
valentinewallace
force-pushed
the
grpc-perf-interceptor
branch
2 times, most recently
from
June 7, 2019 17:50
9c367ca to
920919d
Compare
halseth
reviewed
Jun 11, 2019
Contributor
There was a problem hiding this comment.
should this method possibly return an error if called on !monitoring build?
Start the Prometheus exporter in rpcserver.go if monitoring is enabled through the build tag. Also allow users to specify what address they want the Prometheus exporter to be listening on.
valentinewallace
force-pushed
the
grpc-perf-interceptor
branch
from
June 11, 2019 18:26
920919d to
f5eeb05
Compare
This was referenced Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optionally export lnd gRPC performance metrics for use by a Prometheus server through gRPC interceptors.
If the user compiles
lndwith themonitoringtag, the exporter will automatically start listening for Prometheus requests whenlndstarts up. The user has the option of specifying an address for the exporter to listen on, with the default beinglocalhost:8989.