Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnwallet: add commitment transaction sorting with CLTV tie breaker #3142

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@cfromknecht
Copy link
Collaborator

commented May 30, 2019

Updates commitment transaction sorting to be consistent with lightningnetwork/lightning-rfc#491

Fixes #2234

@cfromknecht cfromknecht added this to the 0.7 milestone May 30, 2019

Show resolved Hide resolved lnwallet/channel.go
@wpaulino
Copy link
Collaborator

left a comment

LGTM 🌪

Would be nice to also bring over the set of tests within txsort to test the input sort order behavior.

cfromknecht added some commits Jun 5, 2019

@cfromknecht cfromknecht force-pushed the cfromknecht:htlc-tie-breaker branch from caf9d26 to b26b88a Jun 5, 2019

@Roasbeef
Copy link
Member

left a comment

LGTM 🏔

@Roasbeef Roasbeef merged commit 970d760 into lightningnetwork:master Jun 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 60.8%
Details

@cfromknecht cfromknecht deleted the cfromknecht:htlc-tie-breaker branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.