Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
htlcswitch: pipeline settles to switch #3143
This PR makes the outgoing link pipeline the settle to the
wpaulino left a comment
Not a blocker, but since there'll be duplicate settles we'll see some error logs that aren't necessary and might lead to users thinking there's an issue. Below are the trace logs for a completed payment:
Jul 11, 2019
Sounds good to me. I think @cfromknecht had some thoughts on possibly refactoring that portion of code to improve clarity of the new behavior, though I'd say it's not a blocker for this PR.
If we don't log the error, we should still return the error and it will still get reported in the link though. So idk if the change is worth it?